Bug 579192 - org.eclipse.jdt.disableMetaIndex confusion
Summary: org.eclipse.jdt.disableMetaIndex confusion
Status: NEW
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Core (show other bugs)
Version: 4.22   Edit
Hardware: All All
: P3 major (vote)
Target Milestone: ---   Edit
Assignee: JDT-Core-Inbox CLA
QA Contact:
URL:
Whiteboard: stalebug
Keywords:
Depends on:
Blocks:
 
Reported: 2022-03-10 05:40 EST by Jörg Kubitz CLA
Modified: 2024-03-10 10:32 EDT (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jörg Kubitz CLA 2022-03-10 05:40:59 EST
We currently have some problems in 4.22 with type hierarchy not always (before indexing finished) finding all types.
I am still digging why. I found bug 570078 may be related.
However the description how to disable that is totally confusing.
The commit message says 
"can be disabled by adding -Dorg.eclipse.jdt.disableMetaIndex=false"

disable with disable=false?

javadoc in org.eclipse.jdt.internal.core.search.indexing.IndexManager.DISABLE_META_INDEX
is also confusing:
"Bug 178816" ? how is that related
"disabled by default" but disabled=false
Comment 1 Gayan Perera CLA 2022-03-10 15:10:16 EST
(In reply to Jörg Kubitz from comment #0)
> We currently have some problems in 4.22 with type hierarchy not always
> (before indexing finished) finding all types.
> I am still digging why. I found bug 570078 may be related.
> However the description how to disable that is totally confusing.
> The commit message says 
> "can be disabled by adding -Dorg.eclipse.jdt.disableMetaIndex=false"
> 
> disable with disable=false?
> 
> javadoc in
> org.eclipse.jdt.internal.core.search.indexing.IndexManager.DISABLE_META_INDEX
> is also confusing:
> "Bug 178816" ? how is that related
> "disabled by default" but disabled=false

I think this was something we missed during some of the last minutes release hiccups Me and Andrey had to fix. I think i missed to change the commit message and javadoc once we flipped it back.

Lets use this issue to correct the javadoc at least to reflect correctly. About default state, i think we kept the metaIndex enable for 2 milestones to see if there are any issues. May be we can try to find a fix for the problem you have already raised.

@Andrey WDYT ?
Comment 2 Jörg Kubitz CLA 2022-03-11 00:45:17 EST
When we disable metaindex until problems solve: do we need to rebuild indexes each time we change "disableMetaIndex" flag?
Comment 3 Gayan Perera CLA 2022-03-11 14:37:37 EST
(In reply to Jörg Kubitz from comment #2)
> When we disable metaindex until problems solve: do we need to rebuild
> indexes each time we change "disableMetaIndex" flag?

No you don't need to change the rebuild the indexes when you disable metaindex. And also when you enable it back its better to rebuild, because the current fallback solution i think we have a issue. The current fallback only support if there are new indexes which are not part of the metaindex. But there could be updates happened for already tracked indexes.

I think we need to find a better fallback logic there.
Comment 4 Eclipse Genie CLA 2024-03-10 10:32:59 EDT
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.