Bug 578893 - [Mac][Dark theme] Remove dark theme workarounds from launcher
Summary: [Mac][Dark theme] Remove dark theme workarounds from launcher
Status: CLOSED WONTFIX
Alias: None
Product: Equinox
Classification: Eclipse Project
Component: Launcher (show other bugs)
Version: unspecified   Edit
Hardware: PC Mac OS X
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard: stalebug
Keywords:
Depends on:
Blocks: 578260
  Show dependency tree
 
Reported: 2022-02-22 07:33 EST by Sravan Kumar Lakkimsetti CLA
Modified: 2024-02-13 15:47 EST (History)
3 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Sravan Kumar Lakkimsetti CLA 2022-02-22 07:33:07 EST
Dark theme issues in mac have been suppressed by using NSRequiresAquaSystemAppearance. This makes eclipse to opt out of dark theme support.

According to https://developer.apple.com/documentation/appkit/nsappearancecustomization/choosing_a_specific_appearance_for_your_macos_app we should do this temporarily only.

Quote from the documentation
------
Important

Supporting Dark Mode is strongly encouraged. Use the NSRequiresAquaSystemAppearance key to opt out temporarily only while you work on improvements to your app's Dark Mode support. If you do not plan to support a dark appearance at all, apply a light appearance to your entire app, as described in Assign a Specific Appearance to Your App.
------

This is suppressing many dark theme issues present in eclipse. This is one reason why eclipse and its run time workbench differs in dark theme support. 

I suggest remove this workaround at the start of 4.24 release and attempt to resolve dark theme issues. If not possible we can reapply this during stabilization period.
Comment 1 Phil Beauvoir CLA 2022-02-22 07:57:05 EST
- Set macOS to use system dark theme
- Remove NSRequiresAquaSystemAppearance from Info.plist
- Launch Eclipse with its Light or System theme

With the above steps there are many rendering issues so not just with Eclipse's Dark theme. If theming is turned off then it looks OK.
Comment 2 Eclipse Genie CLA 2024-02-13 15:47:33 EST
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet. As such, we're closing this bug.

If you have further information on the current state of the bug, please add it and reopen this bug. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.