Bug 578273 - Comparator errors in I20220118-1800
Summary: Comparator errors in I20220118-1800
Status: RESOLVED FIXED
Alias: None
Product: PDE
Classification: Eclipse Project
Component: API Tools (show other bugs)
Version: 4.22   Edit
Hardware: PC All
: P3 normal (vote)
Target Milestone: 4.23 M2   Edit
Assignee: Andrey Loskutov CLA
QA Contact:
URL:
Whiteboard:
Keywords: regression
Depends on:
Blocks:
 
Reported: 2022-01-19 04:02 EST by Andrey Loskutov CLA
Modified: 2022-01-20 05:35 EST (History)
3 users (show)

See Also:


Attachments
buildtimeComparatorUnanticipated.log.txt (5.74 KB, text/plain)
2022-01-19 04:02 EST, Andrey Loskutov CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Andrey Loskutov CLA 2022-01-19 04:02:52 EST
Created attachment 287851 [details]
buildtimeComparatorUnanticipated.log.txt

See https://download.eclipse.org/eclipse/downloads/drops4/I20220118-1800/buildlogs/comparatorlogs/buildtimeComparatorUnanticipated.log.txt

Current assumption that PDE API tools are to blame.
Two changes were merged in I20220117-1800
bug 441654 (https://git.eclipse.org/r/c/pde/eclipse.pde.ui/+/189633) and bug 578243 (https://git.eclipse.org/r/c/pde/eclipse.pde.ui/+/189712).
Comment 1 Vikas Chandra CLA 2022-01-19 04:04:34 EST
api description file has changed. I need to compare the 2 api description files to get further. Likely due to API tool change.
Comment 2 Alexander Kurtakov CLA 2022-01-19 04:13:08 EST
I believe it's coming from bug 578243 . API tools run are from latest I-build.
Local compile failed with:
[/usr/lib/jvm/java-17-openjdk-17.0.1.0.12-13.rolling.fc35.x86_64/bin/java, -Xmx2048M, -Dp2.RepositoryPreferences.retryOnSocketTimeout=true, -Dp2.RepositoryPreferences.connectionRetryCount=3, -Dp2.RepositoryPreferences.connectionMsRetryDelay=500, -Dorg.eclipse.ecf.provider.filetransfer.retrieve.readTimeout=10000, -jar, /home/akurtakov/.m2/repository/p2/osgi/bundle/org.eclipse.equinox.launcher/1.6.400.v20210924-0641/org.eclipse.equinox.launcher-1.6.400.v20210924-0641.jar, -install, /home/akurtakov/git/eclipse.platform.ua/org.eclipse.ui.intro/apiAnalyzer-workspace, -configuration, /home/akurtakov/git/eclipse.platform.ua/org.eclipse.ui.intro/apiAnalyzer-workspace/configuration, -data, /home/akurtakov/git/eclipse.platform.ua/org.eclipse.ui.intro/apiAnalyzer-workspace/data, -application, org.eclipse.pde.api.tools.apiAnalyzer, -project, /home/akurtakov/git/eclipse.platform.ua/org.eclipse.ui.intro, -baseline, /home/akurtakov/git/eclipse.platform.ua/org.eclipse.ui.intro/target/org.eclipse.ui.intro-apiBaseline.target, -dependencyList, /home/akurtakov/git/eclipse.platform.ua/org.eclipse.ui.intro/target/dependencies-list.txt, -failOnError]
Status ERROR: org.eclipse.core.resources code=77 Invalid project description. children=[Status OK: unknown code=0 OK [type: ERROR], [path: null], [message: /home/akurtakov/git/eclipse.platform.ua/org.eclipse.ui.intro overlaps the workspace location: /home/akurtakov/git/eclipse.platform.ua/org.eclipse.ui.intro/apiAnalyzer-workspace/data], [plugin: org.eclipse.core.resources], [exception: null]
Comment 3 Andrey Loskutov CLA 2022-01-19 04:21:40 EST
(In reply to Alexander Kurtakov from comment #2)
> I believe it's coming from bug 578243 . API tools run are from latest
> I-build.
> Local compile failed with:

> /home/akurtakov/git/eclipse.platform.ua/org.eclipse.ui.intro overlaps the
> workspace location:
> /home/akurtakov/git/eclipse.platform.ua/org.eclipse.ui.intro/apiAnalyzer-
> workspace/data], [plugin: org.eclipse.core.resources], [exception: null]

This error is coming from resources bundle, I believe arguments were wrong.
Comment 4 Andrey Loskutov CLA 2022-01-19 04:24:57 EST
Vikas, Alex: any pointers where the SDK build creates ".api_description: different" messages and how those files are computed?
Comment 5 Vikas Chandra CLA 2022-01-19 04:45:22 EST
ApiFileGenerationTask creates api descriptor file.
Comment 6 Eclipse Genie CLA 2022-01-19 04:53:03 EST
New Gerrit change created: https://git.eclipse.org/r/c/pde/eclipse.pde.ui/+/189773
Comment 7 Andrey Loskutov CLA 2022-01-19 04:55:02 EST
(In reply to Vikas Chandra from comment #5)
> ApiFileGenerationTask creates api descriptor file.

Thanks!

(In reply to Eclipse Genie from comment #6)
> New Gerrit change created:
> https://git.eclipse.org/r/c/pde/eclipse.pde.ui/+/189773

Should fix that.
Comment 8 Alexander Kurtakov CLA 2022-01-19 04:59:25 EST
Even after fixing the issue I20220117-1800 should be marked unstable before a rebuild can succeed. Please do so.
Comment 9 Andrey Loskutov CLA 2022-01-19 05:07:59 EST
(In reply to Alexander Kurtakov from comment #8)
> Even after fixing the issue I20220117-1800 should be marked unstable before
> a rebuild can succeed. Please do so.

@Alex: did you mean me? I have no idea how to make a build unstable.


Note for myself: to debug the problem, I've created Eclipse launch config for application org.eclipse.pde.api.tools.apiGeneration and these application arguments:

-projectName Hello 
-project /data/4x_platform_workspace/rt.equinox.framework/bundles/org.eclipse.osgi 
-binary /data/eclipse4.23/eclipse/plugins/org.eclipse.osgi_3.17.200.v20220112-2025.jar 
-target /data/eclipse4.23/api/target

That can be nicely started from debugger & runs pretty fast to be able to bisect the problem.
Comment 10 Andrey Loskutov CLA 2022-01-19 05:10:42 EST
(In reply to Andrey Loskutov from comment #9)
> (In reply to Alexander Kurtakov from comment #8)
> > Even after fixing the issue I20220117-1800 should be marked unstable before
> > a rebuild can succeed. Please do so.
> 
> @Alex: did you mean me? I have no idea how to make a build unstable.

@Sravan: could you please mark I20220117-1800 build unstable?
Comment 11 Alexander Kurtakov CLA 2022-01-19 05:12:31 EST
We need more people to have the knowledge than Sravan and me thus:
Run https://ci.eclipse.org/releng/job/eclipse.releng.markUnstable/ it takes 2 parameters - buildId to mark unstable, bugId of the issue where discussions are held
Comment 13 Andrey Loskutov CLA 2022-01-19 05:19:14 EST
(In reply to Alexander Kurtakov from comment #11)
> We need more people to have the knowledge than Sravan and me thus:
> Run https://ci.eclipse.org/releng/job/eclipse.releng.markUnstable/ it takes
> 2 parameters - buildId to mark unstable, bugId of the issue where
> discussions are held

Thanks, done. 
Next: trigger new build. Which job should I start?
Comment 14 Andrey Loskutov CLA 2022-01-19 05:24:44 EST
(In reply to Andrey Loskutov from comment #13)
> Next: trigger new build. Which job should I start?

I guess https://wiki.eclipse.org/Platform-releng-faq#Trigger_builds_manually
I will git it a try.
Comment 15 Alexander Kurtakov CLA 2022-01-19 06:20:36 EST
(In reply to Andrey Loskutov from comment #14)
> (In reply to Andrey Loskutov from comment #13)
> > Next: trigger new build. Which job should I start?
> 
> I guess https://wiki.eclipse.org/Platform-releng-faq#Trigger_builds_manually
> I will git it a try.

Yes, that's it. Thanks for handling it.
Comment 16 Andrey Loskutov CLA 2022-01-19 09:27:17 EST
(In reply to Andrey Loskutov from comment #14)
> (In reply to Andrey Loskutov from comment #13)
> > Next: trigger new build. Which job should I start?
> 
> I guess https://wiki.eclipse.org/Platform-releng-faq#Trigger_builds_manually
> I will git it a try.

The next I20220119-0540 build is also broken because IDE can't be started without "-data", see https://bugs.eclipse.org/bugs/show_bug.cgi?id=577289#c5.

I will mark I20220119-0540 as unstable too & trigger another build shortly.
Comment 17 Andrey Loskutov CLA 2022-01-20 05:35:51 EST
https://download.eclipse.org/eclipse/downloads/drops4/I20220120-0220/ seem to be fine again (should use I20220119-1320 with the patch).