Description Nicolas Baumann 2022-01-09 05:50:58 EST

When I choose Source->Clean-Up "Pull down common code from if/else statement" on the example below, it results into a compilation failure.

Example:

public class Test {
    private static final int ERROR_ACTION = 0;
    private static final int ACCEPT_ACTION = 1;
    private static final int NUM_RULES = 2;

    public String reduce(int act) {
        String reduceName = "";
        if (act <= NUM_RULES) {
            act--;
        } else if (act > ERROR_ACTION) {
            return reduceName;
        } else {
            if (act < ACCEPT_ACTION) {
                return reduceName;
            }
            return reduceName;
        }
        return reduceName;
    }
}


Result:

public class Test {
    private static final int ERROR_ACTION = 0;
    private static final int ACCEPT_ACTION = 1;
    private static final int NUM_RULES = 2;

    public String reduce(int act) {
        String reduceName = "";
        if (act <= NUM_RULES) {
            act--;
        } else {
            if () {
            }
            return reduceName;
        }
        return reduceName;
    }
}

The empty expression inside the if causes the compilation error.

The example is simplified from the orginal code of org.eclipse.jdt.internal.codeassist.complete.CompletionParser.reduce(int)