Bug 577142 - tmf/lttng: incorrect warning about large automatic offset automatic to be applied
Summary: tmf/lttng: incorrect warning about large automatic offset automatic to be app...
Status: NEW
Alias: None
Product: Tracecompass
Classification: Tools
Component: TMF (show other bugs)
Version: 7.1.0   Edit
Hardware: PC Linux
: P3 normal
Target Milestone: ---   Edit
Assignee: Project Inbox CLA
QA Contact: Project Inbox CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-11-09 08:41 EST by Bernd Hufmann CLA
Modified: 2021-11-09 13:21 EST (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Bernd Hufmann CLA 2021-11-09 08:41:16 EST 
The fix for Bug 484620 (see https://git.eclipse.org/r/c/tracecompass/org.eclipse.tracecompass/+/65330) does an automatic trace offsetting of LTTng Traces of the same host in experiments when the clock_offsets are not the same.

A warning message is supposed to be shown when the clock offset to be applied to each trace is bigger than a CLOCK_OFFSET_THRESHOLD_NS of 500000ns. 

However, the warning seems to be always triggered when there are different clock_offsets in LTTng kernel and ust trace being in an experiment:

!ENTRY org.eclipse.tracecompass.tmf.core 2 0 2021-11-09 08:10:30.605
!MESSAGE Average clock correction (1571659126634839693) is higher than threshold of 500000 ns for experiment [TmfExperiment (seqSession-20191021-104738)]

Looking at the clock_offsets the metadata files I notice that the value that is compared and printed (1571659126634839693) is actually the average clock_offset and but not the delta between clock_offset value of the traces to the average clock_offset.
Comment 1 Bernd Hufmann CLA 2021-11-09 08:51:51 EST 
The log entry is created in method TmfExperiment#initExperiment().