Bug 577103 - Highlight labelled objects in the "Expressions" view too
Summary: Highlight labelled objects in the "Expressions" view too
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Debug (show other bugs)
Version: 4.22   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: 4.23 M2   Edit
Assignee: Zsombor G CLA
QA Contact:
URL:
Whiteboard:
Keywords: noteworthy
Depends on:
Blocks:
 
Reported: 2021-11-06 03:32 EDT by Zsombor G CLA
Modified: 2022-01-27 05:23 EST (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Zsombor G CLA 2021-11-06 03:32:14 EDT
Currently JDIModelPresentation doesnt return foreground color for IWatchExpression and JavaInspectExpression, so if the user labels an object, they wont get highlighted.
Unfortunately, the 'Variables' and the 'Expressions' view use different logic to return the 'Value' of a variable, so we can't easily add the label there.
Comment 1 Eclipse Genie CLA 2021-11-06 03:35:21 EDT
New Gerrit change created: https://git.eclipse.org/r/c/jdt/eclipse.jdt.debug/+/187426
Comment 2 Sarika Sinha CLA 2021-11-08 07:03:58 EST
Can you explain the usecase? 
Variables view has many objects and it makes sense there but in expressions view, what will be the purpose of highlighting?

I believe people will use either Expressions or labelling of objects?
may be I am missing something.
Comment 3 Zsombor G CLA 2021-11-08 07:52:49 EST
The problem, for me, that the 2 views are inconsistent, I would expect that if I label an object, it will show up everywhere as highlighted. Currently, the Expression view highlight the object, only if, that object is not the root one, which looks bad. So, if you label a list, and an item from that list, and you add that list to the Expression view, only the item  will be highlighted.
Comment 4 Eclipse Genie CLA 2022-01-09 13:12:59 EST
New Gerrit change created: https://git.eclipse.org/r/c/jdt/eclipse.jdt.debug/+/189421
Comment 6 Sarika Sinha CLA 2022-01-09 23:25:28 EST
Thanks Zsombor.
Please add N&N entry.
Comment 7 Eclipse Genie CLA 2022-01-17 18:29:12 EST
New Gerrit change created: https://git.eclipse.org/r/c/www.eclipse.org/eclipse/news/+/189722
Comment 9 Sarika Sinha CLA 2022-01-27 05:23:25 EST
I20220126-1800