Bug 576913 - Quickfix "add src.excludes" wrongly adds "source.." entry to build.properties
Summary: Quickfix "add src.excludes" wrongly adds "source.." entry to build.properties
Status: VERIFIED FIXED
Alias: None
Product: PDE
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.22   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 4.22 M3   Edit
Assignee: Vikas Chandra CLA
QA Contact:
URL:
Whiteboard:
Keywords: regression
Depends on:
Blocks:
 
Reported: 2021-10-27 06:49 EDT by Michael Keppler CLA
Modified: 2021-11-10 04:47 EST (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Keppler CLA 2021-10-27 06:49:25 EDT 
1. Remove one of the entries from "src.. = someSourcePath" in build.properties.
2. Use quick fix "Add ... to the src.excludes entry" on the PDE warning that is added to the problems view.
Result: Instead of adding "src.excludes" for the selected source path, "source.." is added.

Root cause: In org.eclipse.pde.internal.ui.correction.AddBuildEntryResolution.createChange(Build) two members of the quick fix class are overridden by some information from the marker. Since there are 2 different quick fixes (add source.., add src.exclude) for the same kind of marker, this cannot work. It basically makes the second kind of quick fix the same as the first one.

Commit f86b4a875bfe12b94e0b7947334f125cea81d11c
Introduced with changes for bug 541334.
Comment 1 Jeff Johnston CLA 2021-11-02 14:58:42 EDT 
Moving to PDE UI
Comment 2 Eclipse Genie CLA 2021-11-09 08:39:22 EST 
New Gerrit change created: https://git.eclipse.org/r/c/pde/eclipse.pde.ui/+/187542
Comment 4 Vikas Chandra CLA 2021-11-09 09:10:38 EST 
Opened Bug 577144 for making AddBuildEntryResolution as multifix
Comment 5 Vikas Chandra CLA 2021-11-10 04:47:39 EST 
verified on
Version: 2021-12 (4.22)
Build id: I20211109-1800