Bug 576809 - Reload Target Plaform vs Reload is confusing
Summary: Reload Target Plaform vs Reload is confusing
Status: NEW
Alias: None
Product: PDE
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.22   Edit
Hardware: PC Windows 10
: P3 normal with 1 vote (vote)
Target Milestone: ---   Edit
Assignee: PDE-UI-Inbox CLA
QA Contact:
URL:
Whiteboard: stalebug
Keywords:
Depends on:
Blocks:
 
Reported: 2021-10-21 09:24 EDT by Lars Vogel CLA
Modified: 2023-11-11 15:48 EST (History)
6 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Lars Vogel CLA 2021-10-21 09:24:09 EDT
In the target editor we have two reloads, one on the top "Reload Target Platform" and "Reload".

Do these two buttons do the same thing? If yes, we should name them the same.
If not, we should align the functionality.
Comment 1 Lars Vogel CLA 2021-10-21 09:25:01 EDT
Alexander, do you know if both the same thing?
Comment 2 Alexander Fedorov CLA 2021-10-21 09:50:23 EDT
(In reply to Lars Vogel from comment #1)
> Alexander, do you know if both the same thing?

Yes, they both do

										`LoadTargetDefinitionJob.load(ITargetDefinition target);`

Link on the top is less widely used in the code, while button belongs to shared UI component.
Comment 3 Lars Vogel CLA 2021-10-21 10:03:58 EDT
(In reply to Alexander Fedorov from comment #2)
> (In reply to Lars Vogel from comment #1)
> > Alexander, do you know if both the same thing?
> 
> Yes, they both do
> 
> 										`LoadTargetDefinitionJob.load(ITargetDefinition target);`
> 
> Link on the top is less widely used in the code, while button belongs to
> shared UI component.

As I (and my client) were confusing by the different labels, I plan to rename the top one to "Reload" to indicate that is does the same.

Thanks, Alexander for the help.
Comment 4 Vikas Chandra CLA 2021-10-21 10:27:56 EDT
I think just "Reload" clears cache target data and then reloads target.
Comment 5 Eclipse Genie CLA 2021-10-21 10:47:08 EDT
New Gerrit change created: https://git.eclipse.org/r/c/pde/eclipse.pde.ui/+/186769
Comment 6 Lars Vogel CLA 2021-10-21 10:51:34 EDT
(In reply to Vikas Chandra from comment #4)
> I think just "Reload" clears cache target data and then reloads target.

Could that be aligned? I think it is highly confusing for users to have two similar buttons doing almost the same.
Comment 7 Lars Vogel CLA 2021-11-09 03:58:49 EST
Hannes, you worked a lot on the target platform. Can you confirm that both "buttons" do the same thing?
Comment 8 Phil Beauvoir CLA 2021-11-09 06:21:33 EST
My understanding:

"Reload" - reloads the the list software sites and IUs
"Reload Target Platform" - synchronises and fetches everything from update sites and resets the PDE target platform and rebuilds

Two different things.
Comment 9 Vikas Chandra CLA 2021-11-09 08:44:31 EST
Reload is specific to target in target definition ( *.target)
Reload Target Platform is common to all kinds of targets.


If you a target in target definition file is resolving and if there is a internet disruption, you would see 
"Problems loading repository".

Reload will fix this.


You can call reload on a target which is not an active target whereas Reload Target platform only happens on active target.
Comment 10 Lars Vogel CLA 2021-11-19 07:07:51 EST
Hannes, IIRC you have plans to allign the different reload behavior so that is consistent. Can you link the corresponding bug to this one?
Comment 11 Hannes Wellmann CLA 2021-11-20 03:53:44 EST
(In reply to Lars Vogel from comment #10)
> Hannes, IIRC you have plans to allign the different reload behavior so that
> is consistent. Can you link the corresponding bug to this one?

That's right, I said that in Bug 576844.
But before starting with this problem, I would like to complete my work with my other pending PDE Bugs/Gerrits first. Therefore I have not yet created any other Bug regarding different reload behaviour.
Comment 12 Eclipse Genie CLA 2023-11-11 15:48:28 EST
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.