575129 – [cleanup] "Optimization" tab should be named "Performance" tab

Bug 575129 - [cleanup] "Optimization" tab should be named "Performance" tab

Summary: [cleanup] "Optimization" tab should be named "Performance" tab

Status:	VERIFIED FIXED

Alias:	None

Product:	JDT
Classification:	Eclipse Project
Component:	UI (show other bugs)
Version:	4.21
Hardware:	All All

Importance:	P3 normal (vote)
Target Milestone:	4.21 M3
Assignee:	Fabrice Tiercelin
QA Contact:	Carsten Hammer

URL:
Whiteboard:
Keywords:	ui

Depends on:
Blocks:

Reported:	2021-07-30 00:25 EDT by Fabrice Tiercelin
Modified:	2021-08-19 04:07 EDT (History)
CC List:	4 users (show)

See Also:	Gerrit Change Gerrit Change Git Commit Gerrit Change Git Commit

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Fabrice Tiercelin

2021-07-30 00:25:18 EDT

The "Optimization" tab in the Cleanup settings should be named "Performance" tab. It is ambiguous. You can also optimize the size of your source code.

Comment 1 Eclipse Genie

2021-07-30 00:43:07 EDT

New Gerrit change created: https://git.eclipse.org/r/c/jdt/eclipse.jdt.ui/+/183538

Comment 2 Fabrice Tiercelin

2021-08-03 14:42:25 EDT

New Gerrit change created: https://git.eclipse.org/r/c/www.eclipse.org/eclipse/news/+/183660

Comment 3 Sarika Sinha

2021-08-13 13:54:23 EDT

We have 2 warnings:
Warning: NLS unused message: PerformanceTabPage_GroupName_Optimization in: org.eclipse.jdt.internal.ui.preferences.cleanup.CleanUpMessages
Warning: NLS missing message: PerformanceTabPage_GroupName_Performance in: org.eclipse.jdt.internal.ui.preferences.cleanup.CleanUpMessages

And the "Performance" Tab itself shows the message of NLS missing message.

Good practice to avoid such things is to verify our code in the I build.

Comment 4 Eclipse Genie

2021-08-13 13:54:58 EDT

New Gerrit change created: https://git.eclipse.org/r/c/jdt/eclipse.jdt.ui/+/183999

Comment 5 Sarika Sinha

2021-08-13 14:03:08 EDT

@Fabrice,
Please update the image in N&N as the current one shows "Optimization" in the group name.

Comment 6 Eclipse Genie

2021-08-13 14:44:27 EDT

Gerrit change https://git.eclipse.org/r/c/jdt/eclipse.jdt.ui/+/183999 was merged to [master].
Commit: http://git.eclipse.org/c/jdt/eclipse.jdt.ui.git/commit/?id=d49550909f938c1b3326065b4189b78bbd4340c6

Comment 7 Eclipse Genie

2021-08-14 03:52:22 EDT

New Gerrit change created: https://git.eclipse.org/r/c/www.eclipse.org/eclipse/news/+/184007

Comment 8 Eclipse Genie

2021-08-14 03:53:34 EDT

Gerrit change https://git.eclipse.org/r/c/www.eclipse.org/eclipse/news/+/184007 was merged to [master].
Commit: http://git.eclipse.org/c/www.eclipse.org/eclipse/news.git/commit/?id=1848eba2e729d3a4830a088bab707156e6953bd3

Comment 9 Noopur Gupta

2021-08-19 04:07:27 EDT

Verified in I20210817-1840.