Community
Participate
Working Groups
Feature request: Can we please show Process ID in Console (so even if we did not start the process in debug mode), Debug View and Process Properties. I often have to find which PID the process has to attach other tools (like profiler) to that process. I'd be happy if someone else implement this.
Created attachment 286662 [details] Suggested Screenshot.png
This should be doable.
Please note, one launch config can host multiple processes, and not every process may have a real process behind AFAIK. At least I've saw such launches.
(In reply to Andrey Loskutov from comment #3) > Please note, one launch config can host multiple processes, and not every > process may have a real process behind AFAIK. At least I've saw such > launches. Yes, but there will be still the main process id, no? Can you attach a sample so that it be used to test/verify for making sure that incorrect data is not displayed?
(In reply to Sarika Sinha from comment #4) > (In reply to Andrey Loskutov from comment #3) > > Please note, one launch config can host multiple processes, and not every > > process may have a real process behind AFAIK. At least I've saw such > > launches. > > Yes, but there will be still the main process id, no? If I read this right, Launch.addProcess() allows to add an unlimited number of processes, so we can't know which one is the main one. In the screenshot we could show pid for the whole only if there is a single process, or show pid's for every hosted process in a launch. > Can you attach a sample so that it be used to test/verify for making sure > that incorrect data is not displayed? No, sorry, just happened to see that somewhere in our product where we create our own launches that represent "virtual" processes that we didn't launched from Eclipse but just connected to. Also I believe one could achieve that by combining multiple run configurations running e.g. external commands via a launch group.
@Jörg, I was thinking of checking if Launch has only one process then show the ID else display "Multiple processes" or some msg like that. Does that sound ok?
> else display "Multiple processes" or some msg like that. > Does that sound ok? I would prefer a comma separated list of PIDs if there is not a strong reason against that.
(In reply to Jörg Kubitz from comment #7) > > else display "Multiple processes" or some msg like that. > > Does that sound ok? > > I would prefer a comma separated list of PIDs if there is not a strong > reason against that. ok.
Adding the pid to the "Process Properties" should be sufficient as it is available even with simple Run and during runtime before termination. Showing Process Ids in the Console will become unnecessary complicated in the case of Group Launches where Processes are added and removed. Any objections?
Can't this be added to the process label in Debug view?
(In reply to Andrey Loskutov from comment #10) > Can't this be added to the process label in Debug view? That will mean changing the getLabel() in the RuntimeProcess and that can show up at many unwanted places as well.
I still would like to see it in console and most important in debug view. And i do not need it for launch groups. Could id be just blank for groups? just add a getLabelWithPid()?
(In reply to Jörg Kubitz from comment #12) > I still would like to see it in console and most important in debug view. > And i do not need it for launch groups. Could id be just blank for groups? > just add a getLabelWithPid()? Platform Debug is base for many debuggers, we have to be really careful as we don't know how these methods are being used. If we add a string to the label and some client is using the label in other places, it might be a totally unexpected and unwanted string for them. There is nothing different about Group launches that we can restrict, they just dynamically keep changing the launches by adding//removing the processes. Process Properties is the safest I feel.
New Gerrit change created: https://git.eclipse.org/r/c/platform/eclipse.platform.debug/+/189453
Created attachment 287807 [details] Proposed change (In reply to Eclipse Genie from comment #14) > New Gerrit change created: > https://git.eclipse.org/r/c/platform/eclipse.platform.debug/+/189453 The screenshot is for the patch above, which is WIP but should show direction I'm thinking about. I think that shouldn't be breaking change (except the quick & dirty change in DebugPlugin.newProcess() I've made because lack of time), and it should cover all three cases - Debug view, Console and Properties. WDYT?
(In reply to Andrey Loskutov from comment #15) > Created attachment 287807 [details] > Proposed change > > (In reply to Eclipse Genie from comment #14) > > New Gerrit change created: > > https://git.eclipse.org/r/c/platform/eclipse.platform.debug/+/189453 > > The screenshot is for the patch above, which is WIP but should show > direction I'm thinking about. > > I think that shouldn't be breaking change (except the quick & dirty change > in DebugPlugin.newProcess() I've made because lack of time), and it should > cover all three cases - Debug view, Console and Properties. > > WDYT? This seems ok, more of a localized change.
@Andrey, Will you be completing the WIP gerrit or I should do it?
New Gerrit change created: https://git.eclipse.org/r/c/jdt/eclipse.jdt.debug/+/189972
(In reply to Sarika Sinha from comment #17) > @Andrey, Will you be completing the WIP gerrit or I should do it? Should be OK for review now.
(In reply to Eclipse Genie from comment #18) > New Gerrit change created: > https://git.eclipse.org/r/c/jdt/eclipse.jdt.debug/+/189972 This will add the pid only in the debug view ? Platform Debug gerrit
(In reply to Sarika Sinha from comment #20) > (In reply to Eclipse Genie from comment #18) > > New Gerrit change created: > > https://git.eclipse.org/r/c/jdt/eclipse.jdt.debug/+/189972 > > This will add the pid only in the debug view ? Yep.
Gerrit change https://git.eclipse.org/r/c/jdt/eclipse.jdt.debug/+/189972 was merged to [master]. Commit: http://git.eclipse.org/c/jdt/eclipse.jdt.debug.git/commit/?id=9ac3d785ae1f6b03bfa2015c4fd2dff145b4964f
Gerrit change https://git.eclipse.org/r/c/platform/eclipse.platform.debug/+/189453 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.debug.git/commit/?id=32800c964bf41dd0f906e3f8c9e5004474883494
New Gerrit change created: https://git.eclipse.org/r/c/www.eclipse.org/eclipse/news/+/190044
thanks Andrey!!
Gerrit change https://git.eclipse.org/r/c/www.eclipse.org/eclipse/news/+/190044 was merged to [master]. Commit: http://git.eclipse.org/c/www.eclipse.org/eclipse/news.git/commit/?id=c5121d8b9d3634c3e081eb987017dda63f060fc7
Verified with build I20220125-1800
(In reply to Eclipse Genie from comment #24) > New Gerrit change created: > https://git.eclipse.org/r/c/www.eclipse.org/eclipse/news/+/190044 Can we add the image of Process Properties page also?
New Gerrit change created: https://git.eclipse.org/r/c/www.eclipse.org/eclipse/news/+/190716
Gerrit change https://git.eclipse.org/r/c/www.eclipse.org/eclipse/news/+/190716 was merged to [master]. Commit: http://git.eclipse.org/c/www.eclipse.org/eclipse/news.git/commit/?id=e2258cd5c60570f400c3f77122ee6e583569bd38
(In reply to Sarika Sinha from comment #28) > Can we add the image of Process Properties page also? Done.
