Bug 574390 - Fix regression in font rendering on export
Summary: Fix regression in font rendering on export
Status: CLOSED FIXED
Alias: None
Product: Sirius
Classification: Modeling
Component: Diagram (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 7.0.0   Edit
Assignee: Pierre-Charles David CLA
QA Contact:
URL:
Whiteboard:
Keywords: triaged
Depends on:
Blocks:
 
Reported: 2021-06-22 10:14 EDT by Pierre-Charles David CLA
Modified: 2022-02-28 04:22 EST (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Pierre-Charles David CLA 2021-06-22 10:14:58 EDT 
Report the new fix for bug #312723 merged in GMF Runtime 1.13.1 into our own copy of GraphicsToGraphics2DAdaptor.

In Sirius 6.3.1 we had https://bugs.eclipse.org/bugs/show_bug.cgi?id=552977 which reported on our side a fix for a font rendering bug in GMF. That fix actually caused regressions in some platforms so it has been partially reverted in the just released GMF Runtime 1.13.1.

We need to report the new fix in our own copy of the code.
Comment 1 Eclipse Genie CLA 2021-06-22 10:23:09 EDT 
New Gerrit change created: https://git.eclipse.org/r/c/sirius/org.eclipse.sirius/+/182351
Comment 3 Pierre-Charles David CLA 2021-07-09 08:26:17 EDT 
Fixed.
Comment 4 Steve Monnier CLA 2022-02-01 18:44:08 EST 
Do you have a validation scenario for this fix?
Based on the GMF bugzilla, I created a diagram with node having different label policies and size. I exported the result in a png image file and the exported result is ok. Can I marked this issue as verified?
Comment 5 Pierre-Charles David CLA 2022-02-02 02:58:28 EST 
Marked as verified given Steve's tests.

To be really complete we would need to test on many combinations (of OS version, screen resolution, Eclipse/SWT version, system zoom setting, SWT DPI configuration, etc.) but it does not seem worth it. From Steve's tests it works in the most common settings (Windows). If people still have issues in specific combinations they will need to report the details.
Comment 6 Pierre-Charles David CLA 2022-02-28 04:22:29 EST 
Available in Sirius 7.0.0, see https://projects.eclipse.org/projects/modeling.sirius/releases/7.0.0