Bug 574264 - Remove icon from target editor as it is confusing with the export button
Summary: Remove icon from target editor as it is confusing with the export button
Status: RESOLVED FIXED
Alias: None
Product: PDE
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.14   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 4.21 M1   Edit
Assignee: Lars Vogel CLA
QA Contact:
URL:
Whiteboard:
Keywords: usability
Depends on:
Blocks:
 
Reported: 2021-06-17 06:42 EDT by Lars Vogel CLA
Modified: 2021-07-22 04:30 EDT (History)
2 users (show)

See Also:

Attachments
target (6.97 KB, image/png)
2021-06-17 06:42 EDT, Lars Vogel CLA 		no flags Details
Target editor without icon (40.16 KB, image/png)
2021-06-17 06:45 EDT, Lars Vogel CLA 		no flags Details
Silly looking icon (1.87 KB, image/png)
2021-06-17 09:39 EDT, Lars Vogel CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Lars Vogel CLA 2021-06-17 06:42:58 EDT 
Created attachment 286608 [details]
target

See screenshot, using the same icon in two location is confusing IMHO. I suggest to remove the first one.
Comment 1 Lars Vogel CLA 2021-06-17 06:45:38 EDT 
Created attachment 286609 [details]
Target editor without icon
Comment 2 Eclipse Genie CLA 2021-06-17 06:47:29 EDT 
New Gerrit change created: https://git.eclipse.org/r/c/pde/eclipse.pde.ui/+/182106
Comment 3 Alexander Fedorov CLA 2021-06-17 07:07:07 EDT 
@Lars
I agree that two [practically] identical icons could confuse. But why you want to remove the first one (on the left)? 
Please have a look on other PDE editors: I can see the icon on the left for many (all?) of them. 
I would rather suggest to change the right icon to be more expressive or replace this right icon with the hyperlink (gives more chances to hit it from the first click :) )
Comment 4 Lars Vogel CLA 2021-06-17 09:39:52 EDT 
Created attachment 286614 [details]
Silly looking icon

Hi Alexander, thanks for the input. Tbh, I think the icons could be removed in all editors as they "only" repeat the icons from the editor tab.

WDYT? Is this icon repetion useful to the user?
Comment 5 Alexander Fedorov CLA 2021-06-17 10:12:33 EDT 
(In reply to Lars Vogel from comment #4)
> Created attachment 286614 [details]
> Silly looking icon
> 
> Hi Alexander, thanks for the input. Tbh, I think the icons could be removed
> in all editors as they "only" repeat the icons from the editor tab.
> 
> WDYT? Is this icon repetion useful to the user?

Well, I can't tell for every user, I can only share my personal experience: after using PDE editors for the last 20 years (OMG), I didn't think until today that there is this left [repeated] icon there.

But, generally, [not silly looking] icons make products more quite.
Comment 6 Lars Vogel CLA 2021-06-18 03:25:06 EDT 
(In reply to Alexander Fedorov from comment #5)

> Well, I can't tell for every user, I can only share my personal experience:
> after using PDE editors for the last 20 years (OMG), I didn't think until
> today that there is this left [repeated] icon there.

Same for me, I never (actively) noticed the icon. I think we should remove them, as they "only" repeat the editor icon and use unnecessary screenspace. I will open a new bug for the other editors.