Bug 574240 - Wrong Note text vertical alignment in collaborative environment
Summary: Wrong Note text vertical alignment in collaborative environment
Status: CLOSED FIXED
Alias: None
Product: Sirius
Classification: Modeling
Component: Diagram (show other bugs)
Version: 6.3.2   Edit
Hardware: PC Windows 10
: P3 normal (vote)
Target Milestone: 6.6.0   Edit
Assignee: Laurent Redor CLA
QA Contact: Glenn Plouhinec CLA
URL:
Whiteboard:
Keywords: triaged
Depends on: 574133 574241
Blocks:
  Show dependency tree
 
Reported: 2021-06-16 11:22 EDT by Laurent Redor CLA
Modified: 2022-01-12 02:16 EST (History)
2 users (show)

See Also:

Attachments
Notes.zip (2.41 KB, application/x-zip-compressed)
2021-06-25 09:46 EDT, Laurent Redor CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Laurent Redor CLA 2021-06-16 11:22:18 EDT 
+++ This bug was initially created as a clone of Bug #574133 +++

The fix done for bug 515044 was broken since Sirius 6.3.2 if Sirius is used in a collaborative environment. In this case, the label of new notes is centered vertically instead of being aligned at the top.

The goal of this issue is to:
* have a SiriusNoteViewFactory less strict (according to the type returned by "EcoreFactory.eINSTANCE.create(EcorePackage.Literals.ESTRING_TO_STRING_MAP_ENTRY)")
* add a migration participant to repair this kind of "broken" notes
Comment 1 Eclipse Genie CLA 2021-06-16 11:30:55 EDT 
New Gerrit change created: https://git.eclipse.org/r/c/sirius/org.eclipse.sirius/+/182051
Comment 3 Laurent Redor CLA 2021-06-25 09:46:17 EDT 
Created attachment 286686 [details]
Notes.zip

Steps to validate (using a data use case made in a collaborative environment)
* Import projet Notes from Notes.zip in your workspace
* Open diagram "new ClassDiag"
* Expected: The label Text2 is centered horizontally AND aligned on the top (not centered vertically).
Comment 4 Eclipse Genie CLA 2021-09-27 04:42:04 EDT 
New Gerrit change created: https://git.eclipse.org/r/c/sirius/org.eclipse.sirius/+/185847
Comment 6 Eclipse Genie CLA 2021-09-27 12:14:37 EDT 
New Gerrit change created: https://git.eclipse.org/r/c/sirius/org.eclipse.sirius/+/185862
Comment 8 Glenn Plouhinec CLA 2021-10-19 10:01:27 EDT 
Validated with ODTE 11.6.0 IT1
Comment 9 Pierre-Charles David CLA 2021-12-10 04:07:02 EST 
Available in Sirius 6.6.0: https://projects.eclipse.org/projects/modeling.sirius/releases/6.6.0
Comment 10 Eclipse Genie CLA 2022-01-12 02:16:16 EST 
New Gerrit change created: https://git.eclipse.org/r/c/sirius/org.eclipse.sirius/+/189515