Bug 573790 - NaiveASTFlattener.java indentation broken
Summary: NaiveASTFlattener.java indentation broken
Status: NEW
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Core (show other bugs)
Version: 4.20   Edit
Hardware: All All
: P3 minor (vote)
Target Milestone: ---   Edit
Assignee: Carsten Hammer CLA
QA Contact:
URL:
Whiteboard: stalebug
Keywords:
Depends on:
Blocks:
 
Reported: 2021-05-26 15:19 EDT by Carsten Hammer CLA
Modified: 2023-10-01 06:30 EDT (History)
3 users (show)

See Also:
manoj.palat: review? (sarika.sinha)


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Carsten Hammer CLA 2021-05-26 15:19:56 EDT
In various situations NaiveASTFlattener injects unneeded spaces to the code.

Of course this is only used for debugging. Nevertheless it is somehow confusing.
Comment 1 Jeff Johnston CLA 2021-05-27 14:16:31 EDT
Hi Carsten,

It would be helpful to include here some examples where you have noted the extraneous spacing as it is hard to tell if it is fixed or not without them and also to review any new tests you add.
Comment 2 Carsten Hammer CLA 2021-05-27 15:48:07 EDT
(In reply to Jeff Johnston from comment #1)
> Hi Carsten,
> 
> It would be helpful to include here some examples where you have noted the
> extraneous spacing as it is hard to tell if it is fixed or not without them
> and also to review any new tests you add.

I fixed some in the gerrit - so it gives you the idea.
Comment 3 Manoj N Palat CLA 2021-06-08 05:52:45 EDT
@Carsten: Given the gerrit, I am assuming you will be working on this for 4.21 M1 - have assigned it to you with 4.21 M1 target.

@Sarika: Could you please do the review?
Comment 4 Carsten Hammer CLA 2021-07-09 07:02:52 EDT
I think this one should only go into a M1 release if at all.
Comment 5 Eclipse Genie CLA 2023-10-01 06:30:21 EDT
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.