Bug 573669 - Cleanup profile showing sub option as a separate entry in the Profile Details
Summary: Cleanup profile showing sub option as a separate entry in the Profile Details
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.20   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 4.20 RC1   Edit
Assignee: Jeff Johnston CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 530122
  Show dependency tree
 
Reported: 2021-05-20 12:27 EDT by Sarika Sinha CLA
Modified: 2021-05-24 06:49 EDT (History)
3 users (show)

See Also:
kalyan_prasad: review+

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sarika Sinha CLA 2021-05-20 12:27:30 EDT 
After the new default cleanup profile, we can see both the entries in details:

Convert 'for' loops to enhanced 'for' loops
Convert to enhanced 'for' loops only if the loop variable is used

If the suboption(Only if variable used) is not selected then it should show:
Convert 'for' loops to enhanced 'for' loops
else
 Convert to enhanced 'for' loops only if the loop variable is used
Comment 1 Sarika Sinha CLA 2021-05-20 12:31:03 EDT 
@Fabrice,
Can you fix this for RC1? 
It will be very confusing for the user.
Comment 2 Fabrice Tiercelin CLA 2021-05-20 14:20:17 EDT 
I fail to reproduce.

@Jeff, do you reproduce?
Comment 3 Eclipse Genie CLA 2021-05-20 18:57:19 EDT 
New Gerrit change created: https://git.eclipse.org/r/c/jdt/eclipse.jdt.ui/+/180831
Comment 4 Jeff Johnston CLA 2021-05-20 18:58:33 EDT 
(In reply to Fabrice Tiercelin from comment #2)
> I fail to reproduce.
> 
> @Jeff, do you reproduce?

Hi Fabrice, this was a bug in the step descriptions (it was issuing two messages if the sub-option was chosen).  I have submitted a patch as it was trivial.
Comment 6 Sarika Sinha CLA 2021-05-24 06:49:48 EDT 
Build id: I20210523-1800