Bug 573629 - Errror running the new default cleanup profile on JDT code
Summary: Errror running the new default cleanup profile on JDT code
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.20   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: 4.21 M1   Edit
Assignee: Jeff Johnston CLA
QA Contact: Jeff Johnston CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 530122 574014
  Show dependency tree
 
Reported: 2021-05-19 04:53 EDT by Lars Vogel CLA
Modified: 2021-07-06 15:44 EDT (History)
3 users (show)

See Also:

Attachments
Screenshot (49.12 KB, image/png)
2021-05-19 04:53 EDT, Lars Vogel CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Lars Vogel CLA 2021-05-19 04:53:37 EDT 
Created attachment 286418 [details]
Screenshot

If I run the new cleanup profile on org.eclipse.help.base I get an error, see attached screenshot.

I replicate, clone https://git.eclipse.org/r/admin/repos/platform/eclipse.platform.ua and run default cleanup profile on org.eclipse.help.base
Comment 1 Lars Vogel CLA 2021-05-28 05:19:48 EDT 
Jeff, can you have a look?
Comment 2 Lars Vogel CLA 2021-05-28 05:32:56 EDT 
Also if I run the default profile on a JDT workspace (with core, debug and ui), I get the following error:

[Working copy] QuickAssistProcessor.java [in org.eclipse.jdt.internal.ui.text.correction [in ui [in org.eclipse.jdt.ui]]] does not exist
Comment 3 Noopur Gupta CLA 2021-05-28 06:00:26 EDT 
Fabrice, please check.
Comment 4 Lars Vogel CLA 2021-06-10 04:42:32 EDT 
Jeff or Fabrice, can you have a look?
Comment 5 Jeff Johnston CLA 2021-06-10 16:33:13 EDT 
I can reproduce with just "Change to Enhanced For loop" + "Organize imports" selected.  Both cleanups work fine on their own.  The following exception trace occurs in jdt.core:

eclipse.buildId=4.20.0.I20210610-1250
java.version=11.0.8
java.vendor=N/A
BootLoader constants: OS=linux, ARCH=x86_64, WS=gtk, NL=en_US
Command-line arguments:  -os linux -ws gtk -arch x86_64 -data /home/jjohnstn/workspace-I20210610

org.eclipse.ltk.ui.refactoring
Error
Thu Jun 10 16:11:21 EDT 2021
Internal Error

Java Model Exception: Java Model Status [[Working copy] HTMLParser.java [in org.apache.lucene.demo.html [in src_demo [in org.eclipse.help.base]]] does not exist]
	at org.eclipse.jdt.internal.core.JavaElement.newJavaModelException(JavaElement.java:584)
	at org.eclipse.jdt.internal.core.Openable.generateInfos(Openable.java:254)
	at org.eclipse.jdt.internal.core.JavaElement.openWhenClosed(JavaElement.java:597)
	at org.eclipse.jdt.internal.core.JavaElement.getElementInfo(JavaElement.java:327)
	at org.eclipse.jdt.internal.core.JavaElement.getElementInfo(JavaElement.java:313)
	at org.eclipse.jdt.internal.core.Openable.getBuffer(Openable.java:296)
	at org.eclipse.jdt.internal.core.Openable.findRecommendedLineSeparator(Openable.java:216)
	at org.eclipse.jdt.internal.core.dom.rewrite.imports.ImportRewriteAnalyzer.<init>(ImportRewriteAnalyzer.java:487)
	at org.eclipse.jdt.core.dom.rewrite.ImportRewrite.rewriteImports(ImportRewrite.java:1329)
	at org.eclipse.jdt.core.manipulation.OrganizeImportsOperation.createTextEdit(OrganizeImportsOperation.java:626)
	at org.eclipse.jdt.internal.corext.fix.ImportsFix.createCleanUp(ImportsFix.java:51)
	at org.eclipse.jdt.internal.ui.fix.ImportsCleanUp.createFix(ImportsCleanUp.java:62)
	at org.eclipse.jdt.internal.corext.fix.CleanUpRefactoring.calculateChange(CleanUpRefactoring.java:772)
	at org.eclipse.jdt.internal.corext.fix.CleanUpRefactoring$CleanUpASTRequestor.calculateSolutions(CleanUpRefactoring.java:301)
	at org.eclipse.jdt.internal.corext.fix.CleanUpRefactoring$CleanUpASTRequestor.acceptAST(CleanUpRefactoring.java:279)
	at org.eclipse.jdt.core.dom.CompilationUnitResolver.resolve(CompilationUnitResolver.java:930)
	at org.eclipse.jdt.core.dom.CompilationUnitResolver.resolve(CompilationUnitResolver.java:614)
	at org.eclipse.jdt.core.dom.ASTParser.createASTs(ASTParser.java:906)
	at org.eclipse.jdt.internal.corext.dom.ASTBatchParser.createASTs(ASTBatchParser.java:82)
	at org.eclipse.jdt.internal.corext.fix.CleanUpRefactoring$CleanUpFixpointIterator.next(CleanUpRefactoring.java:399)
	at org.eclipse.jdt.internal.corext.fix.CleanUpRefactoring.cleanUpProject(CleanUpRefactoring.java:682)
	at org.eclipse.jdt.internal.corext.fix.CleanUpRefactoring.checkFinalConditions(CleanUpRefactoring.java:642)
	at org.eclipse.ltk.core.refactoring.CheckConditionsOperation.run(CheckConditionsOperation.java:86)
	at org.eclipse.ltk.core.refactoring.CreateChangeOperation.run(CreateChangeOperation.java:122)
	at org.eclipse.ltk.core.refactoring.PerformChangeOperation.run(PerformChangeOperation.java:210)
	at org.eclipse.core.internal.resources.Workspace.run(Workspace.java:2313)
	at org.eclipse.core.internal.resources.Workspace.run(Workspace.java:2338)
	at org.eclipse.ltk.internal.ui.refactoring.WorkbenchRunnableAdapter.run(WorkbenchRunnableAdapter.java:89)
	at org.eclipse.jface.operation.ModalContext$ModalContextThread.run(ModalContext.java:122)
Comment 6 Eclipse Genie CLA 2021-06-15 18:26:37 EDT 
New Gerrit change created: https://git.eclipse.org/r/c/jdt/eclipse.jdt.ui/+/182016
Comment 8 Jeff Johnston CLA 2021-06-16 12:11:56 EDT 
Released for 4.21 M1
Comment 9 Jeff Johnston CLA 2021-07-06 15:44:58 EDT 
Verfified for 4.21 M1 using I20210706-0600