Bug 573474 - Next Change in Compare View should navigate to the next change in the git staging view
Summary: Next Change in Compare View should navigate to the next change in the git sta...
Status: NEW
Alias: None
Product: EGit
Classification: Technology
Component: UI (show other bugs)
Version: 5.12   Edit
Hardware: PC Windows 10
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-05-11 04:54 EDT by Max Huang CLA
Modified: 2021-05-11 14:05 EDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Max Huang CLA 2021-05-11 04:54:01 EDT 
Clicking on the Next Change or Previous Change in compare view mode from Git Staging view should honor the preference that is set in the General > Compare/Patch.

If the "Display the next/previous element" option is selected in "When the end/beginning is reached while navigating an element", the compare view should navigate to the next/previous change in the Git Staging view.

Otherwise, user has to click the file in the Unstaged Changes or Staged Changes one by one to compare the diff.
Comment 1 Jeff Johnston CLA 2021-05-11 12:40:32 EDT 
Moving to Eclipse Platform as this would be new function for the TextMergeViewer in concert with git.
Comment 2 Thomas Wolf CLA 2021-05-11 14:01:32 EDT 
No, this would need to be done in EGit. It should allow opening the compare viewer with multiple files selected in the git staging view. The rest would then be handled by the compare framework.

The art lies in constructing a correct CompareEditorInput.
Comment 3 Thomas Wolf CLA 2021-05-11 14:05:55 EDT 
(In reply to Thomas Wolf from comment #2)
> The art lies in constructing a correct CompareEditorInput.

And the difficulty lies in that this CompareEditorInput has to react to index changes.