573109 – Improve logging and error reporting of unhanded escape sequences in the terminal

Bug 573109 - Improve logging and error reporting of unhanded escape sequences in the terminal

Summary: Improve logging and error reporting of unhanded escape sequences in the terminal

Status:	ASSIGNED

Alias:	None

Product:	CDT
Classification:	Tools
Component:	terminal (show other bugs)
Version:	Next
Hardware:	PC Linux

Importance:	P3 normal (vote)
Target Milestone:	---
Assignee:	Jonah Graham
QA Contact:	Jonah Graham

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:	573107 573730
	Show dependency tree

Reported:	2021-04-23 10:00 EDT by Jonah Graham
Modified:	2021-11-15 12:27 EST (History)
CC List:	1 user (show)

See Also:	Git Commit Git Commit Gerrit Change Gerrit Change 574271

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Jonah Graham

2021-04-23 10:00:27 EDT

At the moment errors from decoding escape sequences are silently discarded if full logging is not turned on. As there is a performance impact of full logging* this bug is to try to find the middle ground that allows users to identify and report back cases where escape sequences are not handled by the VT100Emulator

Comment 1 Eclipse Genie

2021-04-24 20:29:10 EDT

Gerrit change https://git.eclipse.org/r/c/cdt/org.eclipse.cdt/+/179701 was merged to [master].
Commit: http://git.eclipse.org/c/cdt/org.eclipse.cdt.git/commit/?id=b7d017572d007bd1bc7e8564b6248229901b41ca

Comment 2 Eclipse Genie

2021-04-24 20:29:12 EDT

Gerrit change https://git.eclipse.org/r/c/cdt/org.eclipse.cdt/+/179702 was merged to [master].
Commit: http://git.eclipse.org/c/cdt/org.eclipse.cdt.git/commit/?id=4ef3cb7f303659fe4c1311cff7b419d7f0b91198

Comment 3 Jonah Graham

2021-05-27 01:37:51 EDT

This takes on more importance with ConPTY - Since ConPTY generates its own stream of escape sequences, we need to know what they are, so having better error reporting is an increased priority. 

I don't see any documentation of what escape sequences ConPTY can generate, although I have already fixed Bug 573713 which was one example of that.

Comment 4 Jonah Graham

2021-09-15 10:32:40 EDT

(Sorry - Covid summer used up too much of my time and these items did not make it into CDT 10.4. Retargetting for 10.5)

Comment 5 Jonah Graham

2021-11-15 12:27:25 EST

I am working on this in the background - but not sure which version of CDT I will get this resolved in.