573086 – DRepresentationDescriptor validity should be triggered in post-commit

Bug 573086 - DRepresentationDescriptor validity should be triggered in post-commit

Summary: DRepresentationDescriptor validity should be triggered in post-commit

Status:	CLOSED FIXED

Alias:	None

Product:	Sirius
Classification:	Modeling
Component:	Core (show other bugs)
Version:	6.4.1
Hardware:	PC Windows 10

Importance:	P3 normal (vote)
Target Milestone:	6.5.0
Assignee:	Steve Monnier
QA Contact:	Laurent Fasani

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2021-04-22 11:11 EDT by Steve Monnier
Modified:	2021-06-02 03:25 EDT (History)
CC List:	1 user (show)

See Also:	Gerrit Change Gerrit Change Git Commit Git Commit

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Steve Monnier

2021-04-22 11:11:44 EDT

DRepresentationDescriptorQuery delegates the computation and storage of the validity of a DRepresentationDescriptor to an adapter. However, when undoing the deletion of a representation, this adapter was triggered too early. At this point the DRepresentationDescriptor was not only transient but was not yet reattached to the resource. This caused a regression in Capella where the label appears grayed. In Sirius, the issue was already there (In Capella there is a LabelProvider that refreshes afterward).

Step to reproduce:
- Open a modeling project
- Open the aird editor
- Remove an existing representation
- Undo
-> The representation should not appear in gray

Comment 1 Eclipse Genie

2021-04-22 11:37:51 EDT

New Gerrit change created: https://git.eclipse.org/r/c/sirius/org.eclipse.sirius/+/179680

Comment 2 Eclipse Genie

2021-04-22 11:37:52 EDT

New Gerrit change created: https://git.eclipse.org/r/c/sirius/org.eclipse.sirius/+/179681

Comment 3 Eclipse Genie

2021-04-27 14:52:56 EDT

Gerrit change https://git.eclipse.org/r/c/sirius/org.eclipse.sirius/+/179680 was merged to [master].
Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=262d3aca36caa96876158bcd59001e6387485bae

Comment 4 Eclipse Genie

2021-04-27 14:54:08 EDT

Gerrit change https://git.eclipse.org/r/c/sirius/org.eclipse.sirius/+/179681 was merged to [master].
Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=f4c2c6304df8f0ca74f42ea5a83e5b5820f895db

Comment 5 Steve Monnier

2021-04-28 06:07:55 EDT

This fix is good enough for Capella because it has a specific label provider that refreshes the project. However, there is still some work needed for a complete fix on Sirius and it is identified in https://bugs.eclipse.org/bugs/show_bug.cgi?id=573209.

There is no validation required here, it will be done with a Capella project in a different issue. Ask me if you need more information.

Comment 6 Pierre-Charles David

2021-06-02 02:43:57 EDT

Available in Sirius 6.5.0, see https://projects.eclipse.org/projects/modeling.sirius/releases/6.5.0 for details.

Comment 7 Laurent Fasani

2021-06-02 03:25:32 EDT

validated with ODCE 11.5

Nevertheless the validation scenario is :
- Open a modeling project
- Open the aird editor
- Remove an existing representation
- Undo
- Double click on the representation
-> The representation is opened

Actually after the undo, the representation appear in grey but the main fix is that the representation can be opened after the undo

Comment 5, indicates the other bugzilla that has been opened for this remaining issue