Bug 572714 - [cleanup] Tests are performed twice
Summary: [cleanup] Tests are performed twice
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.19   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 4.20 M2   Edit
Assignee: Fabrice Tiercelin CLA
QA Contact: Carsten Hammer CLA
URL:
Whiteboard:
Keywords: performance
Depends on:
Blocks:
 
Reported: 2021-04-09 00:28 EDT by Fabrice Tiercelin CLA
Modified: 2021-05-17 14:05 EDT (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Fabrice Tiercelin CLA 2021-04-09 00:28:21 EDT 
Most of the cleanup tests apply the cleanup twice, which is very expensive in running time:
assertGroupCategoryUsed()
assertRefactoringResultAsExpected()

Modifying the assertion signature, it can be done only once for each test.
Comment 1 Eclipse Genie CLA 2021-04-09 00:30:05 EDT 
New Gerrit change created: https://git.eclipse.org/r/c/jdt/eclipse.jdt.ui/+/179059
Comment 3 Fabrice Tiercelin CLA 2021-05-17 14:05:57 EDT 
Verified for 4.20M3 using I20210516-0600 build