Bug 572501 - Runner exit code 0 when AUT launch fails
Summary: Runner exit code 0 when AUT launch fails
Status: ASSIGNED
Alias: None
Product: RCPTT
Classification: Technology
Component: Runner (show other bugs)
Version: 2.5.1   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Project Inbox CLA
QA Contact: Vasili Gulevich CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-03-31 16:46 EDT by Meelis Müür CLA
Modified: 2024-05-14 08:30 EDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Meelis Müür CLA 2021-03-31 16:46:47 EDT 
When running rcptt-maven-plugin, AUT startup failure was still a BUILD SUCCESS and everything was green in CI server.

After some digging, the culprit was this commit: https://eclipse.googlesource.com/rcptt/org.eclipse.rcptt/+/f4f06613f92c15698bae138b662e3379065ebf00%5E!/#F0

org.eclipse.rcptt.runner.util.AUTsManager#launchAutsAndStartTheirThreads will try to launch 11(not 10 as the exception says) times and throws an AutLaunchFail. However the above change in org.eclipse.rcptt.runner.util.TestsRunner#runTests means that AutLaunchFail is caught and info logged and not forwarded to org.eclipse.rcptt.runner.HeadlessRunnerApp#start that has a catch block for AutLaunchFail. As a result exit code 0 is returned instead of 63.
Comment 1 Vasili Gulevich CLA 2024-05-14 08:30:05 EDT 
An attempt to fix the problem:
https://github.com/eclipse/org.eclipse.rcptt/pull/76