Bug 572352 - [save action] Reduce SaveParticipantTest failures
Summary: [save action] Reduce SaveParticipantTest failures
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.19   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 4.20 M1   Edit
Assignee: Fabrice Tiercelin CLA
QA Contact: Jeff Johnston CLA
URL:
Whiteboard:
Keywords: performance
Depends on:
Blocks:
 
Reported: 2021-03-27 06:32 EDT by Fabrice Tiercelin CLA
Modified: 2021-04-06 14:36 EDT (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Fabrice Tiercelin CLA 2021-03-27 06:32:37 EDT
We often face random SaveParticipantTest failures. This ticket does not fix the cause of the problem but reduce the probability of occurrence of such a crash.

It seems that the save action options are changed by a concurrent thread during the tests so this ticket brings the writting and the reading of this options closer. Other computations are done before.

To reduce the timing, the StringBuffer usage have been replaced by a unique String. Indeed, a concatenation of string literals is compiled as one single big string literal.
Comment 1 Eclipse Genie CLA 2021-03-27 06:37:40 EDT
New Gerrit change created: https://git.eclipse.org/r/c/jdt/eclipse.jdt.ui/+/178451
Comment 3 Jeff Johnston CLA 2021-03-31 15:20:29 EDT
Released for 4.20M1
Comment 4 Jeff Johnston CLA 2021-04-06 14:36:38 EDT
Verified for 4.20M1 by examining source repo