Bug 572213 - [cleanup] Dogfooding - Use "Exit loop earlier" in JDT core
Summary: [cleanup] Dogfooding - Use "Exit loop earlier" in JDT core
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Core (show other bugs)
Version: 4.19   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 4.20 M1   Edit
Assignee: Lars Vogel CLA
QA Contact: Fabrice Tiercelin CLA
URL:
Whiteboard:
Keywords:
: 572155 (view as bug list)
Depends on:
Blocks: 571430
  Show dependency tree
 
Reported: 2021-03-23 05:15 EDT by Lars Vogel CLA
Modified: 2021-04-06 03:30 EDT (History)
4 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Lars Vogel CLA 2021-03-23 05:15:50 EDT
This ticket uses and tests the "Exit loop earlier"  cleanup feature:
 - It reviews the feature.
 - It improves performance
If the dogfooding leads to a regression, a ticket should be created for the cleanup and the dogfooding should be pending.

The dogfooding should not be merged if there is opened/reopened bugs related to the cleanup. If a bug is fixed, the dogfooding should be regenerated using the latest version of the feature.

Here is an explanation of the cleanup of Bug 568822:

Before:

for (int i = 0; i < typeArguments.length; i++) {
		if(typeArguments[i] != null) {
			isParameterized = true;
		}
	}

After:

for (int i = 0; i < typeArguments.length; i++) {
		if(typeArguments[i] != null) {
			isParameterized = true;
			break;
		}
	}
Comment 1 Eclipse Genie CLA 2021-03-23 05:19:26 EDT
New Gerrit change created: https://git.eclipse.org/r/c/jdt/eclipse.jdt.core/+/178251
Comment 2 Fabrice Tiercelin CLA 2021-03-27 02:25:53 EDT
*** Bug 572155 has been marked as a duplicate of this bug. ***
Comment 4 Lars Vogel CLA 2021-03-29 08:48:44 EDT
Found one more place.
Comment 5 Eclipse Genie CLA 2021-03-29 08:50:28 EDT
New Gerrit change created: https://git.eclipse.org/r/c/jdt/eclipse.jdt.core/+/178503
Comment 7 Lars Vogel CLA 2021-03-30 05:17:50 EDT
Thanks, Fabrice for the fast reviews.
Comment 8 Vikas Chandra CLA 2021-04-06 03:30:52 EDT
verified by code inspection