Community
Participate
Working Groups
This ticket uses and tests the "Exit loop earlier" cleanup feature: - It reviews the feature. - It improves performance If the dogfooding leads to a regression, a ticket should be created for the cleanup and the dogfooding should be pending. The dogfooding should not be merged if there is opened/reopened bugs related to the cleanup. If a bug is fixed, the dogfooding should be regenerated using the latest version of the feature. Here is an explanation of the cleanup of Bug 568822: Before: for (int i = 0; i < typeArguments.length; i++) { if(typeArguments[i] != null) { isParameterized = true; } } After: for (int i = 0; i < typeArguments.length; i++) { if(typeArguments[i] != null) { isParameterized = true; break; } }
New Gerrit change created: https://git.eclipse.org/r/c/jdt/eclipse.jdt.core/+/178251
*** Bug 572155 has been marked as a duplicate of this bug. ***
Gerrit change https://git.eclipse.org/r/c/jdt/eclipse.jdt.core/+/178251 was merged to [master]. Commit: http://git.eclipse.org/c/jdt/eclipse.jdt.core.git/commit/?id=d582e1ad075577c3466006bbd2b9c77888da4254
Found one more place.
New Gerrit change created: https://git.eclipse.org/r/c/jdt/eclipse.jdt.core/+/178503
Gerrit change https://git.eclipse.org/r/c/jdt/eclipse.jdt.core/+/178503 was merged to [master]. Commit: http://git.eclipse.org/c/jdt/eclipse.jdt.core.git/commit/?id=98d73a5b7aa3afcd5971a300cecede6c7f409664
Thanks, Fabrice for the fast reviews.
verified by code inspection