Bug 572087 - UI blocks after saving modified files due to ProblemsLabelDecorator
Summary: UI blocks after saving modified files due to ProblemsLabelDecorator
Status: CLOSED DUPLICATE of bug 450663
Alias: None
Product: JDT
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.19   Edit
Hardware: PC Windows 10
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: JDT-UI-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords: investigate
Depends on:
Blocks:
 
Reported: 2021-03-18 17:32 EDT by Thomas Whitmore CLA
Modified: 2022-02-06 13:42 EST (History)
2 users (show)

See Also:

Attachments
thread dump (56.16 KB, text/plain)
2021-03-18 17:32 EDT, Thomas Whitmore CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Thomas Whitmore CLA 2021-03-18 17:32:06 EDT 
Created attachment 285882 [details]
thread dump

UI consistently blocks for 6+ seconds when saving modified files. Thread dumps strongly indicate it's the ProblemsLabelDecorator for eg. the Package Explorer or 
Navigator views.


Eclipse IDE for RCP and RAP Developers (includes Incubating components)

Version: 2021-03 (4.19.0)
Build id: 20210312-0638


Eclipse Java Development Tools

Version: 3.18.700.v20210303-1800
Build id: I20210303-1800
Comment 1 Andrey Loskutov CLA 2021-03-18 17:39:39 EDT 
Is this a regression in 4.19, or was it always like this? How big is your workspace, and how many problems are there?
Comment 2 Thomas Whitmore CLA 2021-03-18 17:40:00 EDT 
Possibly related: 
- https://bugs.eclipse.org/bugs/show_bug.cgi?id=346011
Comment 3 Thomas Whitmore CLA 2021-03-18 17:54:30 EDT 
Previously for the same codebase I was using 'Eclipse IDE for Java Developers'

Version: 2019-12 (4.14.0) Build id: 20191212-1212

includes Eclipse Java Development Tools

Version: 3.18.600.v20201202-1800
Build id: I20191210-0610

Saving takes around perhaps 0.4-0.6 seconds there (small pause, not a problem in any way, hard to measure accurately how long it took).

-------------

RAP/RCP workspace has 12,000 Java files and 38,600 markers (35,617 warnings).
Java IDE workspace has same 12,000 Java files and 10,770 markers (9,594 warnings).
Comment 4 Thomas Whitmore CLA 2021-03-18 18:06:26 EDT 
I am definitely used to working in Eclipse (normally just the plain 'Eclipse IDE for Java Developers') with projects up to 100k Java files and have never seen this problem before.

I am not familiar with the Eclipse RCP/RAP, just installed it to try out Bndtools, but I think this may be a regression of some kind.

The problem appears to be related to having the Package Explorer open.
If I close it and have no project tree, or just have the Navigator, I don't encounter the delays.

Looking at the Decorator configuration I didn't find a decorator I could disable to get rid of the Error Markers.
Comment 5 Jörg Kubitz CLA 2021-10-19 06:50:29 EDT 
getErrorTicksFromMarkers duplicates bug 450663
but there are tiny differences in the calling stacktraces
Comment 6 Andrey Loskutov CLA 2022-02-06 13:42:54 EST 

*** This bug has been marked as a duplicate of bug 450663 ***