Bug 571994 - Git staging view not updated after stashing modified file not in Eclipse workspace
Summary: Git staging view not updated after stashing modified file not in Eclipse work...
Status: RESOLVED FIXED
Alias: None
Product: EGit
Classification: Technology
Component: UI (show other bugs)
Version: 5.11   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 5.12   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-03-16 10:37 EDT by Lars Vogel CLA
Modified: 2021-03-19 06:57 EDT (History)
2 users (show)

See Also:

Attachments
Screencast (919.51 KB, image/gif)
2021-03-16 10:37 EDT, Lars Vogel CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Lars Vogel CLA 2021-03-16 10:37:15 EDT 
Created attachment 285855 [details]
Screencast

Stashing seems not to update the Git staging view until the file affected is click upon. See screencast.

Test with latest from nightly update site.
Comment 1 Thomas Wolf CLA 2021-03-16 11:28:47 EDT 
From your screencast I cannot see whether or not this file is in the Eclipse resource tree. Is it?
Comment 2 Lars Vogel CLA 2021-03-16 12:04:18 EDT 
(In reply to Thomas Wolf from comment #1)
> From your screencast I cannot see whether or not this file is in the Eclipse
> resource tree. Is it?

It is outside the Eclipse resource tree i.e. not inside a project.
Comment 3 Thomas Wolf CLA 2021-03-16 13:22:26 EDT 
Can reproduce. Looks like an event is missing somewhere. Don't hold your breath; this will be hard to analyze.
Comment 4 Eclipse Genie CLA 2021-03-17 12:04:09 EDT 
New Gerrit change created: https://git.eclipse.org/r/c/egit/egit/+/177931
Comment 5 Lars Vogel CLA 2021-03-17 12:05:54 EDT 
(In reply to Thomas Wolf from comment #3)
> Can reproduce. Looks like an event is missing somewhere. Don't hold your
> breath; this will be hard to analyze.

Managed to hold my breath :-) , thanks for being so fast.
Comment 7 Thomas Wolf CLA 2021-03-18 04:43:20 EDT 
Stashing triggers a refresh if the index changed. But the index doesn't change if there are no staged modifications that were staged. If there's only working tree changes staged, EGit refreshed only the Eclipse workspace. But if the staged file is outside the workspace (opened from the repo view, for instance), no refresh occurred.