Bug 571610 - Invalid thread access at sequence EditPartRefresh
Summary: Invalid thread access at sequence EditPartRefresh
Status: CLOSED FIXED
Alias: None
Product: Sirius
Classification: Modeling
Component: Diagram (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows 10
: P3 normal (vote)
Target Milestone: 6.5.0   Edit
Assignee: Maxime Porhel CLA
QA Contact: Laurent Redor CLA
URL:
Whiteboard:
Keywords: triaged
Depends on: 571543
Blocks:
  Show dependency tree
 
Reported: 2021-03-02 03:46 EST by Maxime Porhel CLA
Modified: 2021-06-02 02:43 EDT (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Maxime Porhel CLA 2021-03-02 03:46:04 EST 
+++ This bug was initially created as a clone of Bug #571543 +++

The post commit listener org.eclipse.sirius.diagram.sequence.ui.tool.internal.edit.part.SequenceDiagramEditPart.refreshZorder do the refresh of the edit parts contained in the sequence diagram.

The test SequenceExecutionBasicAndReturnMessageTest is broken because when the transaction is executed in a non UI Thread then the post commit is also executed in the no UIThread which lead to SWTException Invalid thread access.

The fi consists in executing the edit part refresh in the UI thread
Comment 2 Maxime Porhel CLA 2021-03-05 04:23:02 EST 
Steps to validate : check the result of SequenceExecutionBasicAndReturnMessageTest
Comment 3 Maxime Porhel CLA 2021-03-07 16:48:37 EST 
Ste(In reply to Maxime Porhel from comment #2)
> Steps to validate : check the result of
> SequenceExecutionBasicAndReturnMessageTest

And LifelineTest.testGMFTextDropInALifelineNotPossible
Comment 4 Laurent Redor CLA 2021-04-13 12:24:07 EDT 
Verified on Sirius 6.5.0-S20210326-125830

The correct name of above test is org.eclipse.sirius.tests.unit.diagram.sequence.LifelineTests.testGMFTextDropInALifelineNotPossible().
Comment 5 Pierre-Charles David CLA 2021-06-02 02:43:57 EDT 
Available in Sirius 6.5.0, see https://projects.eclipse.org/projects/modeling.sirius/releases/6.5.0 for details.