571159 – Cache IPath in ClasspathAccessRule

Bug 571159 - Cache IPath in ClasspathAccessRule

Summary: Cache IPath in ClasspathAccessRule

Status:	VERIFIED FIXED

Alias:	None

Product:	JDT
Classification:	Eclipse Project
Component:	Core (show other bugs)
Version:	4.19
Hardware:	All All

Importance:	P3 enhancement (vote)
Target Milestone:	4.19 M3
Assignee:	Jörg Kubitz
QA Contact:

URL:
Whiteboard:
Keywords:	performance

Depends on:
Blocks:

Reported:	2021-02-12 06:52 EST by Jörg Kubitz
Modified:	2021-02-16 02:01 EST (History)
CC List:	2 users (show)

See Also:	Gerrit Change Git Commit

Attachments
flight recording (73.64 KB, image/png) 2021-02-12 06:53 EST, Jörg Kubitz	no flags	Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Jörg Kubitz

2021-02-12 06:52:46 EST

JDK MC says ~ 1% of our build time is used to convert char[] to IPath in ClasspathAccessRule.getPattern() even if the pattern char[] was created from IPath

i will propose a patch

Comment 1 Jörg Kubitz

2021-02-12 06:53:37 EST

Created attachment 285540 [details]
flight recording

Comment 2 Eclipse Genie

2021-02-12 06:58:45 EST

New Gerrit change created: https://git.eclipse.org/r/c/jdt/eclipse.jdt.core/+/176188

Comment 3 Eclipse Genie

2021-02-12 13:36:13 EST

Gerrit change https://git.eclipse.org/r/c/jdt/eclipse.jdt.core/+/176188 was merged to [master].
Commit: http://git.eclipse.org/c/jdt/eclipse.jdt.core.git/commit/?id=db0505ae83209e88f185623ebb5db1d077ff30f3

Comment 4 Andrey Loskutov

2021-02-15 04:42:26 EST

Thanks Jörg!

Comment 5 Vikas Chandra

2021-02-16 02:01:12 EST

verified by code inspection