Bug 569253 - [ELK] Wrong top-left margins for node in container during arrange at opening
Summary: [ELK] Wrong top-left margins for node in container during arrange at opening
Status: NEW
Alias: None
Product: Sirius
Classification: Modeling
Component: Diagram (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows 10
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords: triaged
Depends on:
Blocks:
 
Reported: 2020-11-27 11:05 EST by Laurent Redor CLA
Modified: 2021-05-05 09:22 EDT (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Laurent Redor CLA 2020-11-27 11:05:04 EST
Currently, in Sirius 6.4.0, the arrange at opening ignores other elements. It is expected to have possible overlap with other existing nodes (this is another improvement). But the top-left margins added for the new layouted elements should be the same than during the arrange all.

There is for example an overlap between the container title and new nodes in it.

Steps to reproduce:
* Create a modeling project with data from "gitSiriusRepo\org.eclipse.sirius\plugins\org.eclipse.sirius.tests.junit\data\unit\layout\withELK"
* Open the diagram "diagramWithContainer" of "packageForArrangeSelectionTest"
* Launch an arrange all
* Expected: No overlap between containers title and content of theses containers: OK
* Save
* Close the diagram
* Replace the My.ecore file with the file contained in "gitSiriusRepo\org.eclipse.sirius\plugins\org.eclipse.sirius.tests.junit\data\unit\layout\withELK\replace"
* Open the diagram "diagramWithContainer"
* Expected: No overlap between containers title and content of theses containers: KO
    * New class "Class2_2_3" overlaps, or almost, the title of container "p2_2". This class should be on the same location than "Class2_2_1".
    * New class "Class1_4" overlaps title of container "p1". This class should be on the same location than "Class1_2" and new class "Class1_3" should be on the same location than "Class1_1".

There are 2 "TODO" comments in org.eclipse.sirius.tests.unit.diagram.layout.SimpleELKLayoutTest.testArrangeAtOpening1(), and 2 others similar in testArrangeAtOpening2(), to validate this change.