Bug 568865 - [target] add advanced editing capabilities for custom target platforms
Summary: [target] add advanced editing capabilities for custom target platforms
Status: RESOLVED FIXED
Alias: None
Product: PDE
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.18   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: 4.19 M1   Edit
Assignee: Christoph Laeubrich CLA
QA Contact:
URL:
Whiteboard:
Keywords: noteworthy, plan
Depends on:
Blocks:
 
Reported: 2020-11-16 14:35 EST by Christoph Laeubrich CLA
Modified: 2021-01-07 12:41 EST (History)
5 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Christoph Laeubrich CLA 2020-11-16 14:35:17 EST 
Currently it is not possible to edit child items of custom target platform items. There are some codes to support this for IU locations but this is all internal and can't be reused.
Comment 1 Eclipse Genie CLA 2020-11-16 14:45:33 EST 
New Gerrit change created: https://git.eclipse.org/r/c/pde/eclipse.pde.ui/+/172330
Comment 3 Andrey Loskutov CLA 2020-12-23 03:26:12 EST 
Releng tests show regression with javadocs, see https://download.eclipse.org/eclipse/downloads/drops4/I20201222-1800/testresults/html/org.eclipse.releng.tests_ep419I-unit-cen64-gtk3-java11_linux.gtk.x86_64_11.html

https://download.eclipse.org/eclipse/downloads/drops4/I20201222-1800/compilelogs/pde.doc.user.javadoc.txt

Please fix new javadoc.

../../../eclipse.pde.ui/ui/org.eclipse.pde.ui/src/org/eclipse/pde/ui/target/ITargetLocationHandler.java:124: error: @param name not found
	 * @param childElementPath
	          ^
../../../eclipse.pde.ui/ui/org.eclipse.pde.ui/src/org/eclipse/pde/ui/target/ITargetLocationHandler.java:137: warning: no description for @param
	 * @param target
	   ^
../../../eclipse.pde.ui/ui/org.eclipse.pde.ui/src/org/eclipse/pde/ui/target/ITargetLocationHandler.java:138: warning: no description for @param
	 * @param treePath
	   ^
../../../eclipse.pde.ui/ui/org.eclipse.pde.ui/src/org/eclipse/pde/ui/target/ITargetLocationHandler.java:139: warning: no description for @param
	 * @param monitor
	   ^
../../../eclipse.pde.ui/ui/org.eclipse.pde.ui/src/org/eclipse/pde/ui/target/ITargetLocationHandler.java:153: warning: no description for @param
	 * @param target
	   ^
../../../eclipse.pde.ui/ui/org.eclipse.pde.ui/src/org/eclipse/pde/ui/target/ITargetLocationHandler.java:154: warning: no description for @param
	 * @param targetLocations
	   ^
../../../eclipse.pde.ui/ui/org.eclipse.pde.ui/src/org/eclipse/pde/ui/target/ITargetLocationHandler.java:165: warning: no description for @param
	 * @param target
	   ^
../../../eclipse.pde.ui/ui/org.eclipse.pde.ui/src/org/eclipse/pde/ui/target/ITargetLocationHandler.java:166: warning: no description for @param
	 * @param treePath
	   ^
../../../eclipse.pde.ui/ui/org.eclipse.pde.ui/src/org/eclipse/pde/ui/target/ITargetLocationHandler.java:179: warning: no description for @param
	 * @param target
	   ^
../../../eclipse.pde.ui/ui/org.eclipse.pde.ui/src/org/eclipse/pde/ui/target/ITargetLocationHandler.java:180: warning: no description for @param
	 * @param treePath
	   ^
1 error
9 warnings
Comment 4 Eclipse Genie CLA 2020-12-23 05:05:19 EST 
New Gerrit change created: https://git.eclipse.org/r/c/pde/eclipse.pde.ui/+/174083
Comment 6 Vikas Chandra CLA 2020-12-23 10:36:41 EST 
Christoph, can you please add N&N items preferably with screenshot of the new UI/functionality? Thanks !
Comment 7 Christoph Laeubrich CLA 2020-12-23 11:25:57 EST 
I'll prepare a Gerrit hopefully the next day for N&N :-)
Comment 8 Vikas Chandra CLA 2020-12-23 12:48:28 EST 
(In reply to Christoph Laeubrich from comment #7)
> I'll prepare a Gerrit hopefully the next day for N&N :-)

ok thanks :-)
Comment 9 Ed Merks CLA 2020-12-30 04:26:45 EST 
I don't think it's ever appropriate to add @Deprecated without documentation.

https://git.eclipse.org/c/pde/eclipse.pde.ui.git/tree/ui/org.eclipse.pde.ui/src/org/eclipse/pde/ui/target/ITargetLocationUpdater.java#n29

There should be @deprecated documentation and it should tell me what the new improvement replacement is.
Comment 10 Vikas Chandra CLA 2021-01-03 04:23:06 EST 
Christoph, since coming week is the M1 week, can you please finish the pending items (like N&N, documentation etc).
Comment 11 Eclipse Genie CLA 2021-01-04 02:50:58 EST 
New Gerrit change created: https://git.eclipse.org/r/c/www.eclipse.org/eclipse/news/+/174201
Comment 12 Christoph Laeubrich CLA 2021-01-04 02:52:00 EST 
(In reply to Vikas Chandra from comment #10)
> Christoph, since coming week is the M1 week, can you please finish the
> pending items (like N&N, documentation etc).

I have added N&N anything else needs to be adjusted?
Comment 13 Mickael Istria CLA 2021-01-04 08:06:44 EST 
(In reply to Christoph Laeubrich from comment #12)
> I have added N&N anything else needs to be adjusted?

I think comment #9 should also be addressed before M1 ideally.
Comment 14 Eclipse Genie CLA 2021-01-05 01:18:16 EST 
New Gerrit change created: https://git.eclipse.org/r/c/pde/eclipse.pde.ui/+/174252
Comment 15 Christoph Laeubrich CLA 2021-01-05 01:22:02 EST 
(In reply to Ed Merks from comment #9)
> https://git.eclipse.org/c/pde/eclipse.pde.ui.git/tree/ui/org.eclipse.pde.ui/
> src/org/eclipse/pde/ui/target/ITargetLocationUpdater.java#n29
> 
> There should be @deprecated documentation and it should tell me what the new
> improvement replacement is.

Done.
Comment 17 Mickael Istria CLA 2021-01-05 03:06:40 EST 
Unless I'm missing something, we're all set there.