Bug 568692 - Product launches that fail should take me to the launch configuration
Summary: Product launches that fail should take me to the launch configuration
Status: NEW
Alias: None
Product: PDE
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.17   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: ---   Edit
Assignee: PDE-UI-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords: bugday, helpwanted, usability
: 568739 (view as bug list)
Depends on:
Blocks:
 
Reported: 2020-11-10 14:41 EST by Nitin Dahyabhai CLA
Modified: 2020-11-13 10:10 EST (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Nitin Dahyabhai CLA 2020-11-10 14:41:20 EST
When a product launch fails plug-in validation, offer to take me to the launch config
that was created. There might be changes I need to make there and not in the product
file for the plug-in selection to become valid.
Comment 1 Mickael Istria CLA 2020-11-12 03:58:03 EST
*** Bug 568739 has been marked as a duplicate of this bug. ***
Comment 2 Nitin Dahyabhai CLA 2020-11-12 10:51:42 EST
I guess this could apply to any Eclipse Application launch?
Comment 3 Mickael Istria CLA 2020-11-12 11:54:31 EST
(In reply to Nitin Dahyabhai from comment #2)
> I guess this could apply to any Eclipse Application launch?

Yes, I think so. Basically anything that shows this dialog is a good candidate.
Comment 4 Mickael Istria CLA 2020-11-13 10:10:48 EST
Here is the stack to the dialog

Thread [main] (Suspended (breakpoint at line 93 in PluginStatusDialog))	
	owns: RunnableLock  (id=274)	
	PluginStatusDialog.setInput(Map<?,?>) line: 93	
	PluginValidationStatusHandler.lambda$0(LaunchValidationOperation, int[]) line: 55	
	1065270329.run() line: not available	
	PendingSyncExec.run() line: 68	
	UILockListener.doPendingWork() line: 171	
	1965798518.run() line: not available	
	RunnableLock.run(Display) line: 40	
	UISynchronizer(Synchronizer).runAsyncMessages(boolean) line: 185	
	Display.runAsyncMessages(boolean) line: 5023	
	Display.readAndDispatch() line: 4529	
	PartRenderingEngine$5.run() line: 1157	
	Realm.runWithDefault(Realm, Runnable) line: 338	
	PartRenderingEngine.run(MApplicationElement, IEclipseContext) line: 1046	
	E4Workbench.createAndRunUI(MApplicationElement) line: 155	
	Workbench.lambda$3(Display, WorkbenchAdvisor, int[]) line: 644	
	1798299644.run() line: not available	
	Realm.runWithDefault(Realm, Runnable) line: 338	
	Workbench.createAndRunWorkbench(Display, WorkbenchAdvisor) line: 551	
	PlatformUI.createAndRunWorkbench(Display, WorkbenchAdvisor) line: 156	
	IDEApplication.start(IApplicationContext) line: 152	
	EclipseAppHandle.run(Object) line: 203	
	EclipseAppLauncher.runApplication(Object) line: 134	
	EclipseAppLauncher.start(Object) line: 104	
	EclipseStarter.run(Object) line: 401	
	EclipseStarter.run(String[], Runnable) line: 255	
	NativeMethodAccessorImpl.invoke0(Method, Object, Object[]) line: not available [native method]	
	NativeMethodAccessorImpl.invoke(Object, Object[]) line: 62	
	DelegatingMethodAccessorImpl.invoke(Object, Object[]) line: 43	
	Method.invoke(Object, Object...) line: 566	
	Main.invokeFramework(String[], URL[]) line: 653	
	Main.basicRun(String[]) line: 590	
	Main.run(String[]) line: 1461	
	Main.main(String[]) line: 1434	


The LaunchValidationOperation op parameter has a (private at the moment) reference ot the launchConfiguration. It would be easy enough to get an access to this launch config and show a link or button to open it in the dialog.