Bug 568579 - [cleanup] An option to skip a cleanup if it will delete a comment
Summary: [cleanup] An option to skip a cleanup if it will delete a comment
Status: ASSIGNED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.17   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: ---   Edit
Assignee: Fabrice Tiercelin CLA
QA Contact: Carsten Hammer CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-11-05 23:51 EST by Fabrice Tiercelin CLA
Modified: 2020-11-05 23:51 EST (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Fabrice Tiercelin CLA 2020-11-05 23:51:17 EST 
Here is what we currently apply about comments in cleanup:
 - When a comment is outside the change, it is kept as it is,
 - When a comment is related to a code that is replaced and functionally does the same thing, it is kept as it is,
 - When the comment is inside a removed code, it is considered as no more relevant.

The user should be able to cancel the rule anytime a comment is lost. The idea is to run all the cleanups safety, so with low review, and then process the remaining cases, requiring a review and corrections.