Bug 568324 - Changed behaviour of PackageFragmentRoot.getHandleIdentifier (resolves classpath now)
Summary: Changed behaviour of PackageFragmentRoot.getHandleIdentifier (resolves classp...
Status: NEW
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Core (show other bugs)
Version: 4.14   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: JDT-Core-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords: regression
Depends on:
Blocks:
 
Reported: 2020-10-28 02:20 EDT by Christian Dietrich CLA
Modified: 2022-11-30 00:10 EST (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Christian Dietrich CLA 2020-10-28 02:20:50 EDT
The behaviour of PackageFragmentRoot.getHandleIdentifier has changed due to the change to PackageFragmentRoot.getHandleMemento(StringBuffer) in 4.14 with https://bugs.eclipse.org/bugs/show_bug.cgi?id=466299.

Whilst getHandleIdentifier seemed to have beed side effect free in older JDT versions, it now may resolve the classpath and thus require a workspace lock.
This is done to retrieve the extra classpath attributes.

I also saw that JarPackageFragmentRoot has an extraAttributes and that a resolved classpath also is available at some places where PackageFragmentRoot and ExternalPackageFragmentRoot are constructed.

Is the side effect oft pot. requirement of workspace lock intended?
can we optimize this by reusing the extra attributes in  JarPackageFragmentRoot and introduce the same extraAttributes for all PackageFragmentRoots

see also https://www.eclipse.org/lists/jdt-dev/msg01628.html
Comment 1 Andrey Loskutov CLA 2020-10-28 02:40:26 EDT
See also real deadlock discussion at Xtext bug tracker https://github.com/eclipse/xtext-eclipse/issues/1562
Comment 2 Eclipse Genie CLA 2022-11-29 20:14:22 EST
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.
Comment 3 Christian Dietrich CLA 2022-11-30 00:10:26 EST
is still relevant