56819 – [key binding] Find Next is mapped to Command+K instead of the normal Command+G

Bug 56819 - [key binding] Find Next is mapped to Command+K instead of the normal Command+G

Summary: [key binding] Find Next is mapped to Command+K instead of the normal Command+G

Status:	ASSIGNED

Alias:	None

Product:	JDT
Classification:	Eclipse Project
Component:	Text (show other bugs)
Version:	3.3
Hardware:	Macintosh Mac OS X - Carbon (unsup.)

Importance:	P3 enhancement with 4 votes (vote)
Target Milestone:	---
Assignee:	JDT-Text-Inbox
QA Contact:

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2004-03-30 15:59 EST by Alex Blewitt
Modified:	2008-08-14 10:26 EDT (History)
CC List:	3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Alex Blewitt

2004-03-30 15:59:28 EST

The Find Next is currently mapped to Command+K (with Find Previous being mapped to 
Command+Shift+K). However, Mac apps use Command+G to find the next element, and 
Command+Shift+G for previous element (see TextApp for an example).

I think there is a good argument for making the Mac commands for finding the same as normal apps, 
because otherwise it's going to confuse people using it.

Command+G is currently bound to 'Declaration in workspace' which is probably much less important 
than a find next/previous.

Comment 1 Douglas Pollock

2004-04-01 10:41:07 EST

I concur.  This was part of the massive overhaul of key bindings that is being 
deferred from 3.0.  Perhaps this particular piece could be considered on its 
own for 3.0.   
 
JDT: can you comment on this?

Comment 2 Alex Blewitt

2007-07-05 17:06:32 EDT

This is still mapped as Command+K on the Mac.

Comment 3 Dani Megert

2007-07-09 06:14:47 EDT

We could change that but the question is whether long time Eclipse users would accept Command+G no longer searching for declarations and Command+K no longer finding the next match (we would need to map Command+K to search for declarations).

André, what's your take on this one?

Comment 4 Alex Blewitt

2007-07-09 15:49:25 EDT

Isn't the 'find next' a global thing, as opposed to the 'find declarations' a JDT thing? Wouldn't those RCP/other text users be expecting a more normal Eclipse mapping?

Comment 5 Markus Keller

2008-08-14 10:26:09 EDT

Firefox, Thunderbird, and Acrobat Reader also use Ctrl+G / Ctrl+Shift+G for Find Next / Find Previous on Windows. I'd say this is the new trend.