Bug 567758 - Add Close to the left and right option to tabs
Summary: Add Close to the left and right option to tabs
Status: VERIFIED FIXED
Alias: None
Product: MAT
Classification: Tools
Component: GUI (show other bugs)
Version: 1.10   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: 1.11.0   Edit
Assignee: Andrew Johnson CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-10-09 09:12 EDT by Andrew Johnson CLA
Modified: 2020-12-18 05:14 EST (History)
0 users

See Also:

Attachments
Screenshot showing move tabs (10.88 KB, image/png)
2020-10-10 05:27 EDT, Andrew Johnson CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Johnson CLA 2020-10-09 09:12:22 EDT 
Ordinary Eclipse now has a menu option on tabs, visible in MAT for Error Log/Notes/Navigation history.
Close to the Left
Close to the Right
See bug 337588

It would be nice to have this for the main area with all the query results.
Close
Close Others
Close to the Left
Close to the Right
----
Close All

Note the new separator. Also only show Close others/left/right if there are tabs to close.
Comment 1 Eclipse Genie CLA 2020-10-09 09:21:12 EDT 
New Gerrit change created: https://git.eclipse.org/r/c/mat/org.eclipse.mat/+/170548
Comment 3 Andrew Johnson CLA 2020-10-10 04:46:47 EDT 
Another useful idea is to be able to move the tabs.
A solution I came up with is to move the current tab left or right, with a keyboard accelerator to make it easy,
and leave the menu active afterwards to allow the tab to be moved again.
I didn't see a way of bringing up the tab pop-up menu, so I added a shift-F10 key listener.
This should be a command/action to allow key binding to be set but I didn't do that.
Comment 4 Eclipse Genie CLA 2020-10-10 04:48:21 EDT 
New Gerrit change created: https://git.eclipse.org/r/c/mat/org.eclipse.mat/+/170582
Comment 6 Andrew Johnson CLA 2020-10-10 05:27:13 EDT 
Created attachment 284417 [details]
Screenshot showing move tabs
Comment 7 Eclipse Genie CLA 2020-10-10 16:01:37 EDT 
New Gerrit change created: https://git.eclipse.org/r/c/mat/org.eclipse.mat/+/170605
Comment 9 Eclipse Genie CLA 2020-10-10 16:31:13 EDT 
New Gerrit change created: https://git.eclipse.org/r/c/mat/org.eclipse.mat/+/170606
Comment 11 Eclipse Genie CLA 2020-10-12 09:22:23 EDT 
New Gerrit change created: https://git.eclipse.org/r/c/mat/org.eclipse.mat/+/170637
Comment 13 Andrew Johnson CLA 2020-10-12 10:35:19 EDT 
The menu is now brought up using a command, active on the editor view, so is using ctrl-F10 to avoid confusion with the context menu on shift-F10.

Test using keyboard to bring up menu with ctrl-F10 once tab is selected, then L/R to move tabs, or up/down to select other options.
Test using mouse to bring up menu on active or non-active tabs, and move using keyboard / mouse.
Check that active tab remains active and toolbar is correct.
Comment 14 Andrew Johnson CLA 2020-10-27 05:24:24 EDT 
The key assignments Ctrl-F8 Ctrl-Shift-F8 are different from Eclipse IDE where than means next/previous perspective.
Ctrl-PageDown and Ctrl-PageUp are already the defaults for tab movement.

Also Ctrl-F10 is show view menu e.g. for the Error log view.
Perhaps Alt-F10 would be better (shift and ctrl are already used)
Comment 15 Eclipse Genie CLA 2020-10-27 07:46:13 EDT 
New Gerrit change created: https://git.eclipse.org/r/c/mat/org.eclipse.mat/+/171342
Comment 17 Eclipse Genie CLA 2020-10-27 09:57:52 EDT 
New Gerrit change created: https://git.eclipse.org/r/c/mat/org.eclipse.mat/+/171359
Comment 19 Andrew Johnson CLA 2020-11-22 08:58:18 EST 
On Ubuntu, ctrl-F10 brings  up the menu, L or R moves the tab, but the menu is not recreated so pressing L again doesn't move the tab
further, unless ctrl-F10 is pressed again first.

Other than that, this task is done.