Community
Participate
Working Groups
The mechanism to add required junit runtime bundles that are missing the target platform hasn't been updated for JUnit 5. Reproduction: * create a default target platform and deselect all org.eclipse.*.junit* bundles * Launch a JUnit 5 test startup fails: !MESSAGE Application error !STACK 1 java.lang.IllegalArgumentException: Bundle "org.eclipse.jdt.junit5.runtime" not found. Possible causes include missing dependencies, too restrictive version ranges, or a non-matching required execution environment. org.eclipse.pde.launching.JUnitLaunchConfigurationDelegate.getRequiredPlugins should return the org.eclipse.jdt.junit5.runtime bundle and its dependencies for JUnit 5 test runners.
New Gerrit change created: https://git.eclipse.org/r/c/pde/eclipse.pde.ui/+/187311
Unfortunately Eclipse SDK tests cannot use Junit 5, see Bug 531057.
Gerrit change https://git.eclipse.org/r/c/pde/eclipse.pde.ui/+/187311 was merged to [master]. Commit: http://git.eclipse.org/c/pde/eclipse.pde.ui.git/commit/?id=3ff15b3b0d860d74c64e9085bc06939aef4d6581
New warning in the nightly build due to this. See https://download.eclipse.org/eclipse/downloads/drops4/I20220314-1800/compilelogs/plugins/org.eclipse.pde.unittest.junit_1.0.200.v20220314-1922/@dot.html
I'll take care of it.
New Gerrit change created: https://git.eclipse.org/r/c/pde/eclipse.pde.ui/+/191886
Gerrit change https://git.eclipse.org/r/c/pde/eclipse.pde.ui/+/191886 was merged to [master]. Commit: http://git.eclipse.org/c/pde/eclipse.pde.ui.git/commit/?id=2ae8a6ac23b3522ba4210204474d81d9da3abf0a
(In reply to Alexander Kurtakov from comment #5) > I'll take care of it. Thank you! I's a pity, but I have to admit that I'm too used to warnings in the PDE code base (other Eclipse plug-ins are similar) so that I just oversaw this. We should consider to make such warnings that are easy to fix errors (although this can become inflationary too) and ideally let the build fail in such cases. Alternatively once PDE has moved to GitHub the QualityGate results could be posted to a PR similar like it is done for Tycho's Unit-Test results: https://github.com/eclipse/tycho/pull/752#issuecomment-1064920890 This would make it harder to oversee new warnings because one does not have to go to a new page. Since Alexander's change is submitted I'm setting this to resolved again.
(In reply to Hannes Wellmann from comment #8) > (In reply to Alexander Kurtakov from comment #5) > > I'll take care of it. > > Thank you! > > I's a pity, but I have to admit that I'm too used to warnings in the PDE > code base (other Eclipse plug-ins are similar) so that I just oversaw this. > We should consider to make such warnings that are easy to fix errors > (although this can become inflationary too) and ideally let the build fail > in such cases. Sadly, this is true. I found it most productive to enable save actions to fix imports, casts and etc. But every bit here helps. We need a critical group of people that strive for that so we can make more things errors, as long as we have many we can't make them errors as it will block any development. > > Alternatively once PDE has moved to GitHub the QualityGate results could be > posted to a PR similar like it is done for Tycho's Unit-Test results: > https://github.com/eclipse/tycho/pull/752#issuecomment-1064920890 One step after the other. Let's first clean up gerrit queue so migration to github is feasible task. After that opportunites are many. We even discussed with Mickael the possibility to have a bot that bumps the version when needed but that's for the "bright future" (tm) . > > This would make it harder to oversee new warnings because one does not have > to go to a new page. > > Since Alexander's change is submitted I'm setting this to resolved again.
(In reply to Alexander Kurtakov from comment #9) > > Sadly, this is true. I found it most productive to enable save actions to > fix imports, casts and etc. But every bit here helps. We need a critical > group of people that strive for that so we can make more things errors, as > long as we have many we can't make them errors as it will block any > development. I would really like to activate save actions but the code has to be clean up first, otherwise I end up with many unrelated changes or would spend a lot of time sorting them out. But I plan to dedicate some changes to automatic and manual clean ups (after the migration to GitHub). I already have many fragmented commits locally with clean-ups I encountered during other work, but I want to group them in a reasonable way. > > > > > Alternatively once PDE has moved to GitHub the QualityGate results could be > > posted to a PR similar like it is done for Tycho's Unit-Test results: > > https://github.com/eclipse/tycho/pull/752#issuecomment-1064920890 > > One step after the other. Let's first clean up gerrit queue so migration to > github is feasible task. After that opportunites are many. We even discussed > with Mickael the possibility to have a bot that bumps the version when > needed but that's for the "bright future" (tm) . > Sure :) Sounds good, I'm looking forward to it!
