Bug 567533 - Reports have a white background with dark theme
Summary: Reports have a white background with dark theme
Status: VERIFIED FIXED
Alias: None
Product: MAT
Classification: Tools
Component: GUI (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows 10
: P3 normal (vote)
Target Milestone: 1.11.0   Edit
Assignee: Andrew Johnson CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-10-01 16:04 EDT by Andrew Johnson CLA
Modified: 2020-12-18 05:23 EST (History)
0 users

See Also:

Attachments
Dark theme with report (114.76 KB, image/png)
2020-10-01 16:08 EDT, Andrew Johnson CLA 		no flags Details
Dark mode after changes (60.01 KB, image/png)
2020-10-02 04:35 EDT, Andrew Johnson CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Johnson CLA 2020-10-01 16:04:43 EDT 
The dark theme now works quite well (see bug 342543) for MAT apart from reports which have white backgrounds and black text.
Window > Preferences > General > Appearance > Theme > 'Dark'
Comment 1 Andrew Johnson CLA 2020-10-01 16:08:34 EDT 
Created attachment 284345 [details]
Dark theme with report

Report has white background, not black
Comment 2 Andrew Johnson CLA 2020-10-01 16:22:03 EDT 
Some of this can be fixed by the style sheet styles.css when the report is viewed in a browser using
@media screen and (prefers-color-scheme: dark)
but the Eclipse browser doesn't honour this.

The pie charts would come out in the wrong colours, but invert() flips white and black
and hue-rotate makes the blues come out blue again.

The simplest way to fix the Eclipse browser display is to copy a new style sheet across when in dark mode.
Comment 3 Eclipse Genie CLA 2020-10-01 16:53:08 EDT 
New Gerrit change created: https://git.eclipse.org/r/c/mat/org.eclipse.mat/+/170184
Comment 5 Eclipse Genie CLA 2020-10-02 03:43:16 EDT 
New Gerrit change created: https://git.eclipse.org/r/c/mat/org.eclipse.mat/+/170197
Comment 7 Andrew Johnson CLA 2020-10-02 04:35:42 EDT 
Created attachment 284349 [details]
Dark mode after changes

Note that the tree lines are still in black inside MAT, so hard to read against the very dark grey table row.
Comment 8 Andrew Johnson CLA 2020-10-02 04:36:53 EDT 
I've fixed the main problems.
The reports look good in Firefox and Chrome.
The charts still have a white background inside MAT, but are reversed in Firefox and Chrome.
The tree lines are black inside MAT, but white in Firefox and Chrome.
Comment 9 Andrew Johnson CLA 2020-10-02 15:39:44 EDT 
I think this is good enough for now, so closing.
Comment 10 Eclipse Genie CLA 2020-10-04 05:52:13 EDT 
New Gerrit change created: https://git.eclipse.org/r/c/mat/org.eclipse.mat/+/170277
Comment 12 Eclipse Genie CLA 2020-10-17 08:57:21 EDT 
New Gerrit change created: https://git.eclipse.org/r/c/mat/org.eclipse.mat/+/170901