Community
Participate
Working Groups
When I select a frame, a "drop to frame", the drop goes on frame too far - i.e. I end up in the frame below the selected frame. Looking at the code, this is because we must perform a "step-into" after we pop the frame that we want to drop. (See JDI 1.4 spec) for ThreadReference.popFrames(StrackFrame). Also, I noticed the code that calls "popFrames()" does not guard against runtime JDI exceptions as all JDI calls should. i.e. try { some jdi } catch (declared exceptions) { targetRequestFailed(...) } catch (RuntimeException e) { targetRequestFailed(...) }
Fixed. Drop to frame now does a step into after popping frames, unless dropping to the top frame.
Please verify.
Made changes to code.
Please see changes to code.
Please verify
Looks good to me.