Bug 5671 - Pop to frame goes one too far
Summary: Pop to frame goes one too far
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Debug (show other bugs)
Version: 2.0   Edit
Hardware: PC Windows 2000
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Jared Burns CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2001-11-08 13:07 EST by Darin Wright CLA
Modified: 2001-11-12 12:00 EST (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Darin Wright CLA 2001-11-08 13:07:39 EST
When I select a frame, a "drop to frame", the drop goes on frame too far - i.e. 
I end up in the frame below the selected frame. Looking at the code, this is 
because we must perform a "step-into" after we pop the frame that we want to 
drop. (See JDI 1.4 spec) for ThreadReference.popFrames(StrackFrame).

Also, I noticed the code that calls "popFrames()" does not guard against 
runtime JDI exceptions as all JDI calls should.

i.e.
try {
   some jdi
} catch (declared exceptions) {
   targetRequestFailed(...)
} catch (RuntimeException e) {
   targetRequestFailed(...)
}
Comment 1 Jared Burns CLA 2001-11-08 14:42:26 EST
Fixed. Drop to frame now does a step into after popping frames, unless dropping
to the top frame.
Comment 2 Jared Burns CLA 2001-11-08 14:42:39 EST
Please verify.
Comment 3 Darin Wright CLA 2001-11-09 10:17:10 EST
Made changes to code. 
Comment 4 Darin Wright CLA 2001-11-09 10:17:33 EST
Please see changes to code.
Comment 5 Darin Wright CLA 2001-11-09 10:17:46 EST
Please verify
Comment 6 Jared Burns CLA 2001-11-12 12:00:29 EST
Looks good to me.