Bug 566499 - Bad license have been introduced to SimRel 2020-09
Summary: Bad license have been introduced to SimRel 2020-09
Status: NEW
Alias: None
Product: MDT.BPMN2
Classification: Modeling
Component: Core (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 major (vote)
Target Milestone: ---   Edit
Assignee: Ralph Soika CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-08-29 06:44 EDT by Ed Merks CLA
Modified: 2020-09-04 11:30 EDT (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ed Merks CLA 2020-08-29 06:44:01 EDT
This commit introduced the badly licensed features:

https://git.eclipse.org/c/simrel/org.eclipse.simrel.build.git/commit/?id=32026dd65c16afd856fdc9d4b87df41393cc16c7
Comment 1 Ed Merks CLA 2020-09-02 03:36:13 EDT
Thanks for following up on this on the cross projects mailing list.

When you have a new p2 repository with fixed versions of the licenses, I can test/verify it for you in advance if you let me know the repository URL.
Comment 2 Eclipse Genie CLA 2020-09-02 05:41:51 EDT
New Gerrit change created: https://git.eclipse.org/r/c/bpmn2/org.eclipse.bpmn2/+/168643
Comment 4 Ed Merks CLA 2020-09-02 12:21:46 EDT
Will such changes fix both these problems?

https://download.eclipse.org/oomph/archive/simrel/soa-bpel.aggrcon/index.html
https://download.eclipse.org/oomph/archive/simrel/mdt-bpmn2.aggrcon/index.html

The runway is short, so if there are repos that can be tested before the final RC2 next week that would be good.  I don't see updates for this week's RC1...
Comment 5 Ralph Soika CLA 2020-09-02 13:39:43 EDT
Yes I have just successful build the new release and updated the repository.

Can you take a look into it?
Comment 6 Ed Merks CLA 2020-09-02 13:44:11 EDT
Yes I can.  What's the URL for it?
Comment 8 Ralph Soika CLA 2020-09-02 14:05:14 EDT
Sorry - wrong links:
I think the File you are interested in is this one:

https://download.eclipse.org/modeling/mdt/bpmn2/updates/2020-09/1.5.1/features/org.eclipse.bpmn2.feature_1.5.1.Final-v20200902-0950.jar
Comment 9 Ed Merks CLA 2020-09-02 14:19:26 EDT
It really does not look promising:

https://download.eclipse.org/oomph/archive/report-bpmn/download.eclipse.org/modeling/mdt/bpmn2/updates/2020-09/1.5.1/index.html

Furthermore, the commit I see really doesn't look right. You are deleting the license property but no where do I see that you're using the license feature as an alternative.

In addition, the bpel problems seem separate, though of the same form.
Comment 10 Ralph Soika CLA 2020-09-02 14:55:52 EDT
ok, then I have to take a closer look at the whole thing and revise it. I'm not going to go along with the 2020-09 release and wait for 2020-12. 

Unfortunately, I took over these projects in a very bad condition. I'll take care of the license issue in the next few weeks. I work in my free time and therefore I cannot invest as much time as is apparently necessary. 

Sorry for that, but I really do my very best.
Comment 11 Eclipse Genie CLA 2020-09-02 18:45:06 EDT
New Gerrit change created: https://git.eclipse.org/r/c/bpmn2/org.eclipse.bpmn2/+/168696
Comment 12 Ed Merks CLA 2020-09-03 02:24:48 EDT
Ralph, sorry for the hassle and thanks for trying to fix it!  And thanks Jonah for helping with changes to use shared license!!

FYI, note that the problems are the actual contents of the repository's content metadata, i.e., https://download.eclipse.org/modeling/mdt/bpmn2/updates/2020-09/1.5.1/content.jar and the content.xml.xz

These have content like this:

      <licenses size='1'>
        <license uri='license.html' url='license.html'>
          Eclipse Public License - v 2.0&#xA;&#xA; 

And that license text is what's presented to the user.  The p2 framework creates a "fingerprint" from this and there are only three valid fingerprints. And confusingly this text should not really be the license text as you might expect from the name, but rather the Software User Agreement text.

If you must have a copy of that text (which is not necessary if you use the shared license feature as Jonah has done), it should be exactly this for SUA 2.0:

https://git.eclipse.org/c/cbi/org.eclipse.license.git/tree/org.eclipse.license/feature.properties

I hope we can iron this out in time for the release.

Note that I can test any repository URL for you even if it's just one still on the build server.  E.g.,

https://ci.eclipse.org/bpmn2/job/bpmn2-mdt/lastSuccessfulBuild/artifact/org.eclipse.bpmn2.site/target/repository/

So if you produce a new build, just let me know and I can test it before it needs to be promoted.

I guess the other problem comes from here:

https://ci.eclipse.org/bpel/job/bpel.nightly/

But here I don't see the update site on the build server.  I guess it ends up here:

https://download.eclipse.org/bpel/updates/nightly/2020-09/

I'm sure we can iron out the problems in time for next week.  (Though I'm traveling next week so it's hard to help in a timely manner then.)

Also the 2020-09 staging repository is tested, so once you contribute the verified fixed versions to SimRel, it will be tested there overnight.
Comment 14 Ralph Soika CLA 2020-09-03 03:18:58 EDT
Thanks for your help and clarifying the situation.
I just merged the commits from Jonah. I will continue working on the project this evening (CET) so it will take some hours until you hear again from me ;-)
Comment 15 Eclipse Genie CLA 2020-09-03 11:40:12 EDT
New Gerrit change created: https://git.eclipse.org/r/c/bpmn2/org.eclipse.bpmn2/+/168765
Comment 17 Ralph Soika CLA 2020-09-03 14:37:45 EDT
Hi Ed, I have an update of the nightly build:

https://ci.eclipse.org/bpmn2/job/bpmn2-mdt/88/

If you find time, can you please take a short look into it if it looks now better?
Comment 19 Eclipse Genie CLA 2020-09-04 06:41:53 EDT
New Gerrit change created: https://git.eclipse.org/r/c/bpel/org.eclipse.bpel/+/168820
Comment 20 Ed Merks CLA 2020-09-04 06:53:54 EDT
I looked at this to see that you're trying to fix BPEL as well, but it's not quite working:

https://ci.eclipse.org/bpel/job/bpel.nightly/lastBuild/console

So I created an Oomph setup to for BPEL to have a local environment.  Then I tried to reproduce your Maven/Tycho build locally, which of course that failed the same way as your ci build.

I think the only changes needed to produce a clean build are the addition of the license-feature and license-feature-version properties on each feature.xml as in this Gerrit:

https://git.eclipse.org/r/c/bpel/org.eclipse.bpel/+/168820

With those local changes I could build your p2 update site locally, and I could test locally that the proper SUA 2.0 licenses are present in that local p2 repository.

I empathize with the messy state BPEL.  Certainly it would benefit greatly from a proper cleanup and also an Oomph setup in which you (or anyone else) could easily reproduce the Maven/Tycho build locally...

Professional help is available... :-P
Comment 22 Ralph Soika CLA 2020-09-04 08:03:21 EDT
Thanks! 
Yes this seems to be the missing part I have overseen. I merged your changes and the nightly build is started...
Comment 23 Ed Merks CLA 2020-09-04 09:13:42 EDT
(In reply to Ralph Soika from comment #22)
> Thanks! 
> Yes this seems to be the missing part I have overseen. I merged your changes
> and the nightly build is started...

I'll keep an eye on it:

https://ci.eclipse.org/bpel/job/bpel.nightly/lastBuild/console

I assume the build will end up here

https://download.eclipse.org/justj/?file=bpel/updates/nightly/2020-09

So I can notice when there is a new timestamp and test it too:

https://download.eclipse.org/bpel/updates/nightly/2020-09/
Comment 24 Ed Merks CLA 2020-09-04 09:28:56 EDT
Oh, I see there's this as well:

https://ci.eclipse.org/bpel/job/bpel.nightly/lastSuccessfulBuild/artifact/site/target/repository/

But the build seems slow; stalled on scanning for projects...

Patience is a virtue...
Comment 26 Ralph Soika CLA 2020-09-04 11:30:11 EDT
Ok, both projects are now updated and published successfully