Bug 565821 - Error log entry "Problem reading cleanUps extensions" during JDT+xtext debug test
Summary: Error log entry "Problem reading cleanUps extensions" during JDT+xtext debug ...
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.17   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: 4.17 M3   Edit
Assignee: Fabrice Tiercelin CLA
QA Contact: Jeff Johnston CLA
URL:
Whiteboard:
Keywords: regression
: 566325 (view as bug list)
Depends on: 562592
Blocks:
  Show dependency tree
 
Reported: 2020-08-05 03:33 EDT by Simeon Andreev CLA
Modified: 2020-08-24 12:22 EDT (History)
5 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simeon Andreev CLA 2020-08-05 03:33:10 EDT 
Our tests ran into the following (sporadically) logged exception:

!ENTRY org.eclipse.jdt.ui 4 10001 2020-08-02 03:25:48.003
!MESSAGE Problem reading cleanUps extensions: cannot satisfy rule for 'org.eclipse.jdt.ui.cleanup.unused_code' to runAfter 'org.eclipse.jdt.ui.cleanup.number_suffix'

The earliest build we have seen this with is:

Eclipse SDK
Version: 2020-09 (4.17)
Build id: I20200731-1239

So far I've not had time to look into reproducing the problem, will comment on this bug as soon as I have some steps.

The test itself is debugging a JDT+xtext based project, as far as I can tell the project is already created and compiled at the time of the error log entry. Debugging however doesn't seem to have started.
Comment 1 Noopur Gupta CLA 2020-08-05 03:42:26 EDT 
Fabrice and Jeff, please take a look.
Comment 2 Andrey Loskutov CLA 2020-08-05 04:03:34 EDT 
Got same error yesterday in my main SDK, also no idea how to reproduce.

eclipse.buildId=4.17.0.I20200803-1800
java.version=11.0.8
java.vendor=N/A
BootLoader constants: OS=linux, ARCH=x86_64, WS=gtk, NL=en_US
Command-line arguments:  -data /data/4x_platform_workspace -os linux -ws gtk -arch x86_64

org.eclipse.jdt.ui
Error
Tue Aug 04 16:40:32 CEST 2020
Problem reading cleanUps extensions: cannot satisfy rule for 'org.eclipse.jdt.ui.cleanup.unused_code' to runAfter 'org.eclipse.jdt.ui.cleanup.number_suffix'
Comment 3 Simeon Andreev CLA 2020-08-05 05:16:33 EDT 
I can reproduce as follows:

1. Start Eclipse in a new workspace.
2. Create a Java 11 project with defaults.
3. Create a minimal snippet with some "hello world" print.
4. Right click in the Java editor, Source -> Clean Up...
5. Cancel the dialog.
6. Observe the Error Log entry:
eclipse.buildId=4.17.0.I20200803-1800
java.version=11.0.7
java.vendor=Oracle Corporation
BootLoader constants: OS=linux, ARCH=x86_64, WS=gtk, NL=en_US
Command-line arguments:  -os linux -ws gtk -arch x86_64 -data /home/sandreev/development_workspaces/contributor_workspace/ws/

org.eclipse.jdt.ui
Error
Wed Aug 05 10:39:22 CEST 2020
Problem reading cleanUps extensions: cannot satisfy rule for 'org.eclipse.jdt.ui.cleanup.unused_code' to runAfter 'org.eclipse.jdt.ui.cleanup.number_suffix'

Once this has occurred, it doesn't re-occur until a restart. After a restart, the same sequence produces the same error log entry.
Comment 4 Jeff Johnston CLA 2020-08-05 17:39:47 EDT 
I believe I have found the problem.

There is another cleanup ObjectEqualsCleanup with the same id as the precompile regex cleanup.  This causes problems for the CleanUp sort algorithm.  I am posting a patch which fixes this issue.
Comment 5 Eclipse Genie CLA 2020-08-05 17:44:41 EDT 
New Gerrit change created: https://git.eclipse.org/r/c/jdt/eclipse.jdt.ui/+/167318
Comment 7 Jeff Johnston CLA 2020-08-06 15:14:55 EDT 
Released for 4.17M3
Comment 8 Jeff Johnston CLA 2020-08-20 14:04:10 EDT 
Verified for 4.17M3 using I20200818-0900 build
Comment 9 Andrey Loskutov CLA 2020-08-24 12:22:57 EDT 
*** Bug 566325 has been marked as a duplicate of this bug. ***