Bug 565071 - Test failures in I20200708-1800
Summary: Test failures in I20200708-1800
Status: ASSIGNED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.17   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: JDT-UI-Inbox CLA
QA Contact:
URL:
Whiteboard: stalebug
Keywords:
Depends on:
Blocks:
 
Reported: 2020-07-09 02:48 EDT by Noopur Gupta CLA
Modified: 2022-10-04 04:25 EDT (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Noopur Gupta CLA 2020-07-09 02:48:25 EDT
gtk3-java11

markTypeOccurrences

java.lang.AssertionError
at org.junit.Assert.fail(Assert.java:87)
at org.junit.Assert.assertTrue(Assert.java:42)
at org.junit.Assert.assertTrue(Assert.java:53)
at org.eclipse.jdt.text.tests.MarkOccurrenceTest.assertOccurrences(MarkOccurrenceTest.java:425)
at org.eclipse.jdt.text.tests.MarkOccurrenceTest.markTypeOccurrences(MarkOccurrenceTest.java:183)

The test passes locally.
Comment 1 Noopur Gupta CLA 2020-07-09 06:36:06 EDT
testOverride4

win32-java11

expected:<2> but was:<3>

java.lang.AssertionError: expected:<2> but was:<3>
at org.junit.Assert.fail(Assert.java:89)
at org.junit.Assert.failNotEquals(Assert.java:835)
at org.junit.Assert.assertEquals(Assert.java:647)
at org.junit.Assert.assertEquals(Assert.java:633)
at org.eclipse.jdt.text.tests.contentassist.CodeCompletionTest1d8.testOverride4(CodeCompletionTest1d8.java:370)

The test passes locally.
Comment 2 Noopur Gupta CLA 2020-08-20 17:28:46 EDT
(In reply to Noopur Gupta from comment #1)
> testOverride4
> 
> win32-java11
> 
> expected:<2> but was:<3>
> 
> java.lang.AssertionError: expected:<2> but was:<3>
> at org.junit.Assert.fail(Assert.java:89)
> at org.junit.Assert.failNotEquals(Assert.java:835)
> at org.junit.Assert.assertEquals(Assert.java:647)
> at org.junit.Assert.assertEquals(Assert.java:633)
> at org.eclipse.jdt.text.tests.contentassist.CodeCompletionTest1d8.testOverride4(CodeCompletionTest1d8.java:370)
> 
> The test passes locally.

Also failed in I20200820-0230.
Comment 3 Noopur Gupta CLA 2020-08-27 02:37:12 EDT
(In reply to Noopur Gupta from comment #2)
> (In reply to Noopur Gupta from comment #1)
> > testOverride4
> > 
> > win32-java11
> > 
> > expected:<2> but was:<3>
> > 
> > java.lang.AssertionError: expected:<2> but was:<3>
> > at org.junit.Assert.fail(Assert.java:89)
> > at org.junit.Assert.failNotEquals(Assert.java:835)
> > at org.junit.Assert.assertEquals(Assert.java:647)
> > at org.junit.Assert.assertEquals(Assert.java:633)
> > at org.eclipse.jdt.text.tests.contentassist.CodeCompletionTest1d8.testOverride4(CodeCompletionTest1d8.java:370)
> > 
> > The test passes locally.
> 
> Also failed in I20200820-0230.
Also in I20200826-1800.
Comment 4 Carsten Hammer CLA 2020-08-28 12:29:04 EDT
Would it be possible to use the same java version and the same file encoding for the windows and the linux build? Currently I see

Windows build
https://download.eclipse.org/eclipse/downloads/drops4/I20200828-0150/testresults/xml/org.eclipse.jdt.text.tests_ep417I-unit-win32-java11_win32.win32.x86_64_11.xml

file.encoding=Cp1252
java AdoptOpenJDK jdk-11.0.7.10-hotspot

Linux build
https://download.eclipse.org/eclipse/downloads/drops4/I20200828-0150/testresults/xml/org.eclipse.jdt.text.tests_ep417I-unit-cen64-gtk3-java11_linux.gtk.x86_64_11.xml

file.encoding=UTF-8
java Oracle OpenJDK 64-Bit Server VM 11.0.2+9

I know these differences do not necessarily mean a lot but it is easier to exclude a possible reason when they are as close as possible configured.
Comment 5 Carsten Hammer CLA 2020-08-30 02:31:38 EDT
Can someone tell me why the java versions differ? Imho the project plan is wrong this way. There are different java versions mentioned:
https://www.eclipse.org/eclipse/development/plans/eclipse_project_plan_4_17.xml#target_environments
Comment 6 Noopur Gupta CLA 2020-08-30 07:15:27 EDT
(In reply to Carsten Hammer from comment #4)
> Would it be possible to use the same java version and the same file encoding
> for the windows and the linux build? Currently I see
> 
> Windows build
> https://download.eclipse.org/eclipse/downloads/drops4/I20200828-0150/testresults/xml/org.eclipse.jdt.text.tests_ep417I-unit-win32-java11_win32.win32.x86_64_11.xml
> 
> 
> file.encoding=Cp1252
> java AdoptOpenJDK jdk-11.0.7.10-hotspot
> 
> Linux build
> https://download.eclipse.org/eclipse/downloads/drops4/I20200828-0150/testresults/xml/org.eclipse.jdt.text.tests_ep417I-unit-cen64-gtk3-java11_linux.gtk.x86_64_11.xml
> 
> 
> file.encoding=UTF-8
> java Oracle OpenJDK 64-Bit Server VM 11.0.2+9
> 
> I know these differences do not necessarily mean a lot but it is easier to
> exclude a possible reason when they are as close as possible configured.

Sravan, do you have any idea on this?
Comment 7 Carsten Hammer CLA 2020-08-30 17:37:40 EDT
As there are a number of usages of the default encoding I guess the file.encoding does matter and should better be equal on the windows build and linux build. Here some code locations that make use of it:

eclipse.jdt.ui/org.eclipse.jdt.ui/core refactoring/org/eclipse/jdt/internal/corext/refactoring/binary/AbstractCodeCreationOperation.java:89 Found reliance on default encoding in org.eclipse.jdt.internal.corext.refactoring.binary.AbstractCodeCreationOperation.createCompilationUnit(IFileStore, String, String, IProgressMonitor): String.getBytes() [Of Concern(19), High confidence]
eclipse.jdt.ui/org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/compare/JavaCompareAction.java:81 Found reliance on default encoding in org.eclipse.jdt.internal.ui.compare.JavaCompareAction$TypedElement.getContents(): String.getBytes() [Of Concern(19), High confidence]
eclipse.jdt.ui/org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/text/java/hover/JavadocHover.java:1056 Found reliance on default encoding in org.eclipse.jdt.internal.ui.text.java.hover.JavadocHover.loadStyleSheet(String): new java.io.InputStreamReader(InputStream) [Of Concern(19), High confidence]
eclipse.jdt.ui/org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/preferences/formatter/FormatterProfileStore.java:80 Found reliance on default encoding in org.eclipse.jdt.internal.ui.preferences.formatter.FormatterProfileStore.readOldForCompatibility(IScopeContext): new java.io.FileReader(File) [Of Concern(19), High confidence]
eclipse.jdt.ui/org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/propertiesfileeditor/PropertyKeyHyperlinkDetector.java:102 Found reliance on default encoding in org.eclipse.jdt.internal.ui.propertiesfileeditor.PropertyKeyHyperlinkDetector.detectHyperlinks(ITextViewer, IRegion, boolean): String.getBytes() [Of Concern(19), High confidence]
eclipse.jdt.ui/org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/preferences/formatter/ProfileStore.java:192 Found reliance on default encoding in org.eclipse.jdt.internal.ui.preferences.formatter.ProfileStore.readProfilesFromString(String): String.getBytes() [Of Concern(19), High confidence]
eclipse.jdt.ui/org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/preferences/PropertiesFileEditorPreferencePage.java:693 Found reliance on default encoding in org.eclipse.jdt.internal.ui.preferences.PropertiesFileEditorPreferencePage.loadPreviewContentFromFile(String): new java.io.InputStreamReader(InputStream) [Of Concern(19), High confidence]
eclipse.jdt.ui/org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/text/java/AbstractJavaCompletionProposal.java:686 Found reliance on default encoding in org.eclipse.jdt.internal.ui.text.java.AbstractJavaCompletionProposal.getCSSStyles(): new java.io.InputStreamReader(InputStream) [Of Concern(19), High confidence]
eclipse.jdt.ui/org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/preferences/JavaEditorColoringConfigurationBlock.java:912 Found reliance on default encoding in org.eclipse.jdt.internal.ui.preferences.JavaEditorColoringConfigurationBlock.loadPreviewContentFromFile(String): new java.io.InputStreamReader(InputStream) [Of Concern(19), High confidence]
eclipse.jdt.ui/org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/fix/CleanUpRefactoringWizard.java:493 Found reliance on default encoding in org.eclipse.jdt.internal.ui.fix.CleanUpRefactoringWizard$CleanUpConfigurationPage.decodeSettings(String): String.getBytes() [Of Concern(19), High confidence]
eclipse.jdt.ui/org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/compare/JavaCompareUtilities.java:347 Found reliance on default encoding in org.eclipse.jdt.internal.ui.compare.JavaCompareUtilities.getBytes(String, String): String.getBytes() [Of Concern(19), High confidence]
eclipse.jdt.ui/org.eclipse.jdt.ui/core refactoring/org/eclipse/jdt/internal/corext/refactoring/changes/DeletePackageFragmentRootChange.java:164 Found reliance on default encoding in org.eclipse.jdt.internal.corext.refactoring.changes.DeletePackageFragmentRootChange.getFileLength(IFile): new java.io.InputStreamReader(InputStream) [Of Concern(19), High confidence]
eclipse.jdt.ui/org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/preferences/formatter/ProfileStore.java:176 Found reliance on default encoding in org.eclipse.jdt.internal.ui.preferences.formatter.ProfileStore.writeProfiles(Collection, IScopeContext): java.io.ByteArrayOutputStream.toString() [Of Concern(19), High confidence]
eclipse.jdt.ui/org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/fix/CleanUpRefactoringWizard.java:481 Found reliance on default encoding in org.eclipse.jdt.internal.ui.fix.CleanUpRefactoringWizard$CleanUpConfigurationPage.encodeSettings(Map): java.io.ByteArrayOutputStream.toString() [Of Concern(19), High confidence]
eclipse.jdt.ui/org.eclipse.jdt.ui/core refactoring/org/eclipse/jdt/internal/corext/refactoring/nls/NLSHintHelper.java:450 Found reliance on default encoding in org.eclipse.jdt.internal.corext.refactoring.nls.NLSHintHelper.getProperties(IStorage): String.getBytes() [Of Concern(19), High confidence]
eclipse.jdt.ui/org.eclipse.jdt.ui/ui refactoring/org/eclipse/jdt/internal/ui/refactoring/nls/search/NLSSearchResultRequestor.java:430 Found reliance on default encoding in org.eclipse.jdt.internal.ui.refactoring.nls.search.NLSSearchResultRequestor.createInputStream(IFile): String.getBytes() [Of Concern(19), High confidence]
Comment 8 Sravan Kumar Lakkimsetti CLA 2020-08-31 00:22:14 EDT
(In reply to Noopur Gupta from comment #6)
> (In reply to Carsten Hammer from comment #4)
> > Would it be possible to use the same java version and the same file encoding
> > for the windows and the linux build? Currently I see
> > 
> > Windows build
> > https://download.eclipse.org/eclipse/downloads/drops4/I20200828-0150/testresults/xml/org.eclipse.jdt.text.tests_ep417I-unit-win32-java11_win32.win32.x86_64_11.xml
> > 
> > 
> > file.encoding=Cp1252
> > java AdoptOpenJDK jdk-11.0.7.10-hotspot
> > 
> > Linux build
> > https://download.eclipse.org/eclipse/downloads/drops4/I20200828-0150/testresults/xml/org.eclipse.jdt.text.tests_ep417I-unit-cen64-gtk3-java11_linux.gtk.x86_64_11.xml
> > 
> > 
> > file.encoding=UTF-8
> > java Oracle OpenJDK 64-Bit Server VM 11.0.2+9
> > 
> > I know these differences do not necessarily mean a lot but it is easier to
> > exclude a possible reason when they are as close as possible configured.
> 
> Sravan, do you have any idea on this?

We use installed version of java for official tests. We can switch to adoptopenjdk if required.
Comment 10 Carsten Hammer CLA 2020-08-31 01:46:38 EDT
(In reply to Sravan Kumar Lakkimsetti from comment #9)
> here are the test results with java 11.0.7 on linux
> https://ci.eclipse.org/releng/view/Automated%20tests/job/ep417I-unit-cen64-
> gtk3-java11-noopur/3/artifact/workarea/I20200830-1800/eclipse-testing/
> results/xml/org.eclipse.jdt.text.tests_ep417I-unit-cen64-gtk3-java11-
> noopur_linux.gtk.x86_64_11.xml

I think using this version is better - even if it is not a problem in this case to use a different java version. Not sure if the project plan should be changed to reflect using AdoptOpenJDK...
Comment 11 Noopur Gupta CLA 2020-09-03 08:27:19 EDT
(In reply to Noopur Gupta from comment #3)
> (In reply to Noopur Gupta from comment #2)
> > (In reply to Noopur Gupta from comment #1)
> > > testOverride4
> > > 
> > > win32-java11
> > > 
> > > expected:<2> but was:<3>
> > > 
> > > java.lang.AssertionError: expected:<2> but was:<3>
> > > at org.junit.Assert.fail(Assert.java:89)
> > > at org.junit.Assert.failNotEquals(Assert.java:835)
> > > at org.junit.Assert.assertEquals(Assert.java:647)
> > > at org.junit.Assert.assertEquals(Assert.java:633)
> > > at org.eclipse.jdt.text.tests.contentassist.CodeCompletionTest1d8.testOverride4(CodeCompletionTest1d8.java:370)
> > > 
> > > The test passes locally.
> > 
> > Also failed in I20200820-0230.
> Also in I20200826-1800.
Again in I20200902-1800.
Comment 12 Noopur Gupta CLA 2020-10-08 07:13:30 EDT
(In reply to Noopur Gupta from comment #11)
> (In reply to Noopur Gupta from comment #3)
> > (In reply to Noopur Gupta from comment #2)
> > > (In reply to Noopur Gupta from comment #1)
> > > > testOverride4
> > > > 
> > > > win32-java11
> > > > 
> > > > expected:<2> but was:<3>
> > > > 
> > > > java.lang.AssertionError: expected:<2> but was:<3>
> > > > at org.junit.Assert.fail(Assert.java:89)
> > > > at org.junit.Assert.failNotEquals(Assert.java:835)
> > > > at org.junit.Assert.assertEquals(Assert.java:647)
> > > > at org.junit.Assert.assertEquals(Assert.java:633)
> > > > at org.eclipse.jdt.text.tests.contentassist.CodeCompletionTest1d8.testOverride4(CodeCompletionTest1d8.java:370)
> > > > 
> > > > The test passes locally.
> > > 
> > > Also failed in I20200820-0230.
> > Also in I20200826-1800.
> Again in I20200902-1800.

Also in I20201007-1800.
Comment 13 Noopur Gupta CLA 2020-10-08 07:23:49 EDT
(In reply to Noopur Gupta from comment #12)
> > > > > testOverride4

Moved to bug 567713.
Comment 14 Eclipse Genie CLA 2022-10-04 04:25:14 EDT
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.