Bug 564925 - Add colorDefinitions for color preferences
Summary: Add colorDefinitions for color preferences
Status: NEW
Alias: None
Product: Eclemma
Classification: Technology
Component: General (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 enhancement
Target Milestone: ---   Edit
Assignee: Project inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-07-04 09:11 EDT by Pierre-Yves Bigourdan CLA
Modified: 2020-07-04 09:13 EDT (History)
0 users

See Also:


Attachments
Theme CSS (20.64 KB, image/png)
2020-07-04 09:13 EDT, Pierre-Yves Bigourdan CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Pierre-Yves Bigourdan CLA 2020-07-04 09:11:02 EDT
It would be handy if Eclemma's color preferences were also exposed as color definitions, in particular when writing custom Eclipse themes.

Attached is a screenshot with on top the IEclipsePreferences attribute that must currently be specified to modify the colors. The preferences are opaque strings which are harder to work with.

On the bottom is the alternative approach that would become possible if the preferences had a color definition associated with them. This results in clean and flexible CSS that integrates nicely with editors: no warnings, different color formats supported, color preview, direct edition via the system's color selector, etc. You can make use of richer CSS features, such as combining attributes, referencing a different attribute, etc.

As a similar example, JDT UI exposes all of its color preferences via color definitions: https://github.com/eclipse/eclipse.jdt.ui/blob/c385b31c51214389d5092c34d2d58eeab011be16/org.eclipse.jdt.ui/plugin.xml#L6484
Comment 1 Pierre-Yves Bigourdan CLA 2020-07-04 09:13:23 EDT
Created attachment 283509 [details]
Theme CSS