Bug 56449 - Need to know if a reference match is in Javadoc or in Code
Summary: Need to know if a reference match is in Javadoc or in Code
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Core (show other bugs)
Version: 3.0   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.0 M9   Edit
Assignee: Jerome Lanneluc CLA
QA Contact:
URL:
Whiteboard:
Keywords:
: 51357 (view as bug list)
Depends on:
Blocks: 54892 56392
  Show dependency tree
 
Reported: 2004-03-27 06:32 EST by Dirk Baeumer CLA
Modified: 2004-05-18 12:45 EDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dirk Baeumer CLA 2004-03-27 06:32:27 EST 
To filter matches in Javadoc in the new search we need to know if the match is 
inside code or Javadoc.
Comment 1 Dirk Baeumer CLA 2004-03-27 06:33:43 EST 
Philippe, can we add this early M9 ?
Comment 2 Philipe Mulet CLA 2004-03-29 04:53:58 EST 
Fair request.
Comment 3 Jerome Lanneluc CLA 2004-03-29 11:53:18 EST 
Would adding isJavaDocReference() on FieldReferenceMatch, MethodReferenceMatch 
and TypeReferenceMatch suit your needs?
Comment 4 Dirk Baeumer CLA 2004-03-29 13:05:46 EST 
I think yes. Thomas, any additional comments.
Comment 5 Thomas M??der CLA 2004-03-30 03:19:48 EST 
Can we abstract this out somehow (i.e. I'd rather not do 3 instance checks ored
together)?
Comment 6 Jerome Lanneluc CLA 2004-03-30 03:30:51 EST 
Ok I will factor it to JavaSearchMatch.isJavaDocReference() and this will 
return false for the declaration matches.
Comment 7 Jerome Lanneluc CLA 2004-03-30 11:52:15 EST 
After talking to Philippe, a better name is insideDocComment().
Comment 8 Jerome Lanneluc CLA 2004-03-31 04:41:54 EST 
Added JavaSearchMatch.insideDocComment() and added tests 
JavaSearchTests.testFieldReferenceInOutDocComment(), 
testMethodReferenceInOutDocComment() and testTypeReferenceInOutDocComment().
Comment 9 Markus Keller CLA 2004-03-31 08:45:25 EST 
*** Bug 51357 has been marked as a duplicate of this bug. ***
Comment 10 Frederic Fusier CLA 2004-05-18 12:09:51 EDT 
Verified for 3.0 M9 with build I200405180816.
Comment 11 Frederic Fusier CLA 2004-05-18 12:27:42 EDT 
Note that this does not work for package references, but I'll open a new bug to
address this issue...
Comment 12 Frederic Fusier CLA 2004-05-18 12:45:06 EDT 
See bug 62697 for package references matches problem...