Bug 564446 - Outdated jvmdi parameters like -Djava.compiler=NONE
Summary: Outdated jvmdi parameters like -Djava.compiler=NONE
Status: NEW
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Debug (show other bugs)
Version: 4.16   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: JDT-Debug-Inbox CLA
QA Contact:
URL:
Whiteboard: stalebug
Keywords:
Depends on:
Blocks:
 
Reported: 2020-06-18 16:09 EDT by Carsten Hammer CLA
Modified: 2022-06-24 17:51 EDT (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Carsten Hammer CLA 2020-06-18 16:09:24 EDT
A text search of "-Xdebug" reveals different classes to setup JVMDI for tests and real work in jdt.ui, jdt.core and jdt.debug. While there seem to be some code duplication between the 3 projects I wonder if differences like usage of outdated parameters can be harmful.
There has been some effort to mitigate impact as you can see here

https://bugs.java.com/bugdatabase/view_bug.do?bug_id=6272174

see SocketLaunchingConnectorImpl.launch()
or AbstractJDITest.launchSunTarget()

compared to this in StandardVMDebugger this option is only choosen for java versions up to 1.3

			//check if java 1.4 or greater
			if (version < 1.4) {
				arguments.add("-Djava.compiler=NONE"); //$NON-NLS-1$
			}
Comment 1 Sarika Sinha CLA 2020-06-19 00:27:25 EDT
Can you point to the jdt.ui and jdt.core code which works differently?
Comment 2 Carsten Hammer CLA 2020-06-19 13:47:39 EDT
usage of -Djava.compiler=NONE

jdt.core  no (commented) DRLVMLauncher.java
jdt.core  no             JRockitVMLauncher.java
jdt.core  no (commented  MacVMLauncher.java
jdt.core  no (commented) SideCarJ9VMLauncher.java
jdt.core  no (commented) SideCarVMLauncher.java 
jdt.core  no (commented) StandardVMLauncher.java
jdt.debug yes            SocketLaunchingConnectorImpl.java
jdt.debug yes            AbstractJDITest.java
jdt.debug yes            RemoteJavaApplicationTests.java
jdt.debug yes (java<1.4) StandardVMDebugger.java


settings only mentioned in the javadoc
jdt.ui    no             InvocationCountExampleTest.java
jdt.ui    no             InvocationCountPerformanceMeter.java
Comment 3 Eclipse Genie CLA 2022-06-24 17:51:37 EDT
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.