Bug 564323 - broken caching of TracingOptionsManager::getTracingTemplateCopy
Summary: broken caching of TracingOptionsManager::getTracingTemplateCopy
Status: VERIFIED FIXED
Alias: None
Product: PDE
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.6   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 4.17 M1   Edit
Assignee: Julian Honnen CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-06-16 04:28 EDT by Julian Honnen CLA
Modified: 2020-07-07 05:20 EDT (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Julian Honnen CLA 2020-06-16 04:28:04 EDT
The caching mechanism of TracingOptionsManager::getTracingTemplateCopy is broken since bug 274176:

	public synchronized Properties getTracingTemplateCopy() {
		if (template == null) {
			template = createTemplate();
		}
		return (Properties) createTemplate().clone();
	}

The bug fixed concurrent initialization and invalidation of the template field by making relevant methods synchronized but also changed the lazy getter to the version above.

This causes the tracing template to be computed for every selection of a launch configuration.
Comment 1 Eclipse Genie CLA 2020-06-16 06:22:47 EDT
New Gerrit change created: https://git.eclipse.org/r/164977
Comment 3 Vikas Chandra CLA 2020-07-07 04:14:08 EDT
Julian, can you please verify the bug.
Comment 4 Julian Honnen CLA 2020-07-07 05:20:14 EDT
verified with I20200706-2300