Bug 564295 - TypeHierarchyViewPart does not call updateActionBars
Summary: TypeHierarchyViewPart does not call updateActionBars
Status: CLOSED WONTFIX
Alias: None
Product: JDT
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.16   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 4.17 M3   Edit
Assignee: Rolf Theunissen CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-06-15 07:10 EDT by Rolf Theunissen CLA
Modified: 2020-07-26 07:24 EDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Rolf Theunissen CLA 2020-06-15 07:10:27 EDT 
TypeHierarchyViewPart uses actionbars to create to toolbar for the view.
i.e. getViewSite().getActionBars() and actionBars.getToolBarManager().

However, the view does not call getToolBarManager, instead update() is called directly. The documentation of getToolBarManager clearly states that this most be done to propagate throughout the workbench. For instance, if getToolBarManager is not called, the E4 model will not be updated.

More and more the UI will be completely driven by the E4 model, therefore, expect that in the near future the toolbar will not be visible anymore.
Comment 1 Lars Vogel CLA 2020-06-15 07:22:20 EDT 
Thanks, Rolf. I assume you will push a Gerrit here, hence I assign it to you.
Comment 2 Rolf Theunissen CLA 2020-07-26 07:24:35 EDT 
The IActionBars protocol is violated on many places, there is hardly any client that calls updateActionBars.
It will be impossible to fix all clients, and it is useless to change only one. Therefore won't fix this one.

Opened Bug 565549 to find a general solution to the underlying problem.