Bug 564005 - Commit and Push button does not use pushurl by default
Summary: Commit and Push button does not use pushurl by default
Status: NEW
Alias: None
Product: EGit
Classification: Technology
Component: UI (show other bugs)
Version: 5.7   Edit
Hardware: All All
: P3 minor (vote)
Target Milestone: ---   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-06-05 14:42 EDT by Alex Blewitt CLA
Modified: 2022-02-18 13:38 EST (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Blewitt CLA 2020-06-05 14:42:19 EDT 
If I have a Git repository with a remote configured as:

$ git remote -v                                                                                  origin	git://git.eclipse.org/gitroot/platform/eclipse.platform.runtime.git (fetch)
origin	ssh://ablewitt@git.eclipse.org:29418/platform/eclipse.platform.runtime (push)

On the command line, 'git push' will use the ssh variant. When I click on 'Commit and Push' from the Git Staging view, it will use the 'url' instead of the 'pushurl' for the repository (which will fail in this case).

It would be good if the commit-and-push button and wizard could auto-select the pushurl if it exists in the configuration.
Comment 1 Thomas Wolf CLA 2020-06-06 04:45:57 EDT 
Somehow I cannot reproduce this. Could you post the whole git config?
Comment 2 Alex Blewitt CLA 2020-06-06 05:21:09 EDT 
If you have the url and pushurl as different, in the drop-down list it defaulted to the url (in my case). I was able to change it in the dialog so that it chose the pushurl and use that; but my point is that it should be the default :)

Here was my .git config:

--- 8< ---
[core]
	repositoryformatversion = 0
	filemode = true
	logallrefupdates = true
	precomposeunicode = true
[remote "origin"]
	url = git://git.eclipse.org/gitroot/platform/eclipse.platform.runtime.git
	fetch = +refs/heads/*:refs/remotes/origin/*
	pushurl = ssh://ablewitt@git.eclipse.org:29418/platform/eclipse.platform.runtime
	push = HEAD:refs/for/master
[branch "master"]
	remote = origin
	merge = refs/heads/master
[branch "bug563262"]
	remote = origin
	merge = refs/heads/master
--- 8< ---
Comment 3 Thomas Wolf CLA 2020-06-06 05:45:28 EDT 
Can you try with EGit nightly? I cannot reproduce this with current master. The dialog uses the configured pushurl for me.
Comment 4 Alex Blewitt CLA 2020-06-06 06:02:36 EDT 
Will do, and report back.
Comment 5 Thomas Wolf CLA 2022-02-18 13:38:30 EST 
Alex, I've never been able to reproduce this. Is this still an issue?