Community
Participate
Working Groups
Using M3. Go to preferences -> Java -> Editor -> Code Minings. Change the state of the "Enable code minigns" checkbox. All the other controls on the page should change their enabled state to match the new checkbox state. This doesn't happen. I have to click "Apply and Close" and then open the prefences window again to see the correct enabled state.
Regression is caused by another "optimization" patch https://git.eclipse.org/r/#/c/162024/ that does not even have an appropriated bug. I plan to revert this "optimization" for 4.16 RC1.
Revert patch: https://git.eclipse.org/r/163512. Requires another revert patch https://git.eclipse.org/r/#/c/163450/ for another "optimization" patch https://git.eclipse.org/r/#/c/163450/ that went into RC1 without a bug and approval. Noopur, please check & approve.
Gerrit change https://git.eclipse.org/r/163512 was merged to [master]. Commit: http://git.eclipse.org/c/jdt/eclipse.jdt.ui.git/commit/?id=65eb83ab919266b2124370fc6af8e693559825c2
Apologize, looks like we have another issue here. Clicking exact on the checkbox square disables/enables everything fine, clicking a pixel away from it on the text of the checkbox only switches the check mark inside the checkbox, but does not changes the state of the underlined options. So while bisecting I've probably had bad luck to click few pixels away. Now knowing that crazy behavior of this checkbox, I see this is a regression is from 4.14, not from 4.16.
New Gerrit change created: https://git.eclipse.org/r/163808
Created attachment 283114 [details] Screenshot (In reply to Eclipse Genie from comment #5) > New Gerrit change created: https://git.eclipse.org/r/163808 After changes in OptionsConfigurationBlock, I see that the text with a link is moved to the right e.g. in the null annotations preference. See attached screenshot. It was due to the "gd.horizontalIndent= 4;" line. The change that was setting offset to 0 on Linux is probably fine but I couldn't test it as I don't have a Linux machine. Please open a bug for 4.17 M1 if it needs to be changed. I have reverted both the changes in OptionsConfigurationBlock in the above patch. +1 to release the remaining part for RC2 which fixes the enable code minings issue.
Gerrit change https://git.eclipse.org/r/163808 was merged to [master]. Commit: http://git.eclipse.org/c/jdt/eclipse.jdt.ui.git/commit/?id=74e0ebe4a07d746d3bdf35a922be4613a5f88ebd
Mateusz/Andrey, can you please verify if the reported issue is fixed for you?
(In reply to Noopur Gupta from comment #8) > Mateusz/Andrey, can you please verify if the reported issue is fixed for you? Comment 4 is still valid on I20200602-0510, in I20200602-1800 bug is fixed.
Created attachment 283141 [details] Linux before changes to OptionsConfigurationBlock
Created attachment 283142 [details] Linux after changes to OptionsConfigurationBlock
(In reply to Noopur Gupta from comment #6) > Created attachment 283114 [details] > Screenshot > > (In reply to Eclipse Genie from comment #5) > > New Gerrit change created: https://git.eclipse.org/r/163808 > > After changes in OptionsConfigurationBlock, I see that the text with a link > is moved to the right e.g. in the null annotations preference. See attached > screenshot. It was due to the "gd.horizontalIndent= 4;" line. > > The change that was setting offset to 0 on Linux is probably fine but I > couldn't test it as I don't have a Linux machine. Please open a bug for 4.17 > M1 if it needs to be changed. > > I have reverted both the changes in OptionsConfigurationBlock in the above > patch. > > +1 to release the remaining part for RC2 which fixes the enable code minings > issue. Hi Noopur. After experimenting, the correct solution is to change the -2 to 4 (instead of 0) and remove the gd.horizontalIndent so it won't affect Windows/Mac. I will open a separate bug against Linux for 4.17 and propose the fix.
(In reply to Andrey Loskutov from comment #9) > Comment 4 is still valid on I20200602-0510, in I20200602-1800 bug is fixed. Thanks, Andrey.
(In reply to Jeff Johnston from comment #12) > Hi Noopur. After experimenting, the correct solution is to change the -2 to > 4 (instead of 0) and remove the gd.horizontalIndent so it won't affect > Windows/Mac. I will open a separate bug against Linux for 4.17 and propose > the fix. Sure, thanks Jeff. The text is indeed overlapping in your screenshot. We will check with other Linux users also to verify it as this hasn't been reported yet by anyone.
