Description Garret Wilson 2020-05-22 11:21:44 EDT

This bug is very similar to Bug 560889, except in the opposite direction: it unnecessarily indents code when I save, rather than wrapping lines.

I'm using the Eclipse Enterprise package 2020-06 (4.16.0) M2 (20200507-0346) on AdoptOpenJDK 11, with an almost identical formatting configuration to Bug 560889.

If I hit `Ctrl+Shift+F` it reformats the code nicely. Then I hit `Ctrl+S` to save, and it _indents_ two lines.

Here is an excerpt of code. (I don't have time to break it down into a minimal reproducible example. Hopefully since it's yet another manifestation of very similar bugs which keep cropping up, you'll be able to find the source with this example. And I can't help the crummy presentation; that's what we get for using Bugzilla rather than something modern.)

```
	protected List<Element> regenerateNavigationList(@Nonnull MummyContext context, @Nonnull final Artifact contextArtifact, @Nonnull final Artifact artifact,
			@Nonnull final Element navigationListElement) throws IOException, DOMException {

//stuff cut here to make the example smaller

		//add new navigation links from templates
		navigation(context, contextArtifact)
				//generate navigation elements 
				.forEach(navigationItem -> {
					//if the navigation artifact is this artifact, use the template for an active link
							final Element liTemplate = navigationItem.equals(contextArtifact) ? activeLiTemplate : inactiveLiTemplate;
					final Element liElement = (Element)liTemplate.cloneNode(true);
					//update the icon: <li><i> (transform to <span></span>)
					findFirst(liElement.getElementsByTagNameNS(XHTML_NAMESPACE_URI_STRING, ELEMENT_I)).map(Element.class::cast).ifPresent(iElement -> {
						//if the navigation element has an icon, replace the `<i></i>` with an icon `<span></span>` 
								navigationItem.findIconId().ifPresentOrElse(iconId -> {
							final String iconClass;
							final String iconContent;
							final String[] iconIdParts = iconId.split("/", -1); //TODO use constant
							if(iconIdParts.length == 2 && !iconIdParts[0].isBlank() && !iconIdParts[1].isBlank()) {
								final String iconGroup = iconIdParts[0];
								final String iconName = iconIdParts[1];
								if(FONT_AWESOME_ICON_GROUPS.contains(iconGroup)) {
									iconClass = iconGroup + ' ' + iconName; //e.g. `<span class="fas fa-home"></span>` (Font Awesome)
									iconContent = null;
								} else {
									iconClass = iconGroup; //e.g. `<span class="material-icons">home</span>` (Material Icons)
									iconContent = iconName;
								}
							} else { //if the icon name isn't in the format we expect, just use it as the content
								iconClass = null;
								iconContent = iconId;
							}
							final Element iconElement = iElement.getOwnerDocument().createElementNS(XHTML_NAMESPACE_URI_STRING, ELEMENT_SPAN);
							if(iconClass != null) {
								iconElement.setAttributeNS(null, ATTRIBUTE_CLASS, iconClass);
							}
							if(iconContent != null) {
								appendText(iconElement, iconContent);
							}
							iElement.getParentNode().replaceChild(iconElement, iElement);
						}, () -> iElement.getParentNode().removeChild(iElement)); //if the navigation element has no icon, remove the `<i></i>`
					});
					//update the link: <li><a>
					findFirst(liElement.getElementsByTagNameNS(XHTML_NAMESPACE_URI_STRING, ELEMENT_A)).map(Element.class::cast).ifPresent(aElement -> {
								navigationItem.findHref().ifPresentOrElse(href -> aElement.setAttributeNS(null, ELEMENT_A_ATTRIBUTE_HREF, href),
										() -> aElement.removeAttributeNS(null, ELEMENT_A_ATTRIBUTE_HREF));
						//remove text nodes (leaving the icon or any other element)
						final Iterator<Node> childNodeIterator = XmlDom.childNodesIterator(aElement);
						while(childNodeIterator.hasNext()) {
							final Node childNode = childNodeIterator.next();
							if(childNode.getNodeType() == Node.TEXT_NODE) {
								childNodeIterator.remove();
							}
						}
								final String navigationLabel = navigationItem.getLabel();
						final String linkLabel = aElement.getChildNodes().getLength() > 0 ? " " + navigationLabel : navigationLabel; //add spacing if there are other elements (e.g. an icon)
						//append the link label
						appendText(aElement, linkLabel);
					});
					navigationListElement.appendChild(liElement);
				});

		return List.of(navigationListElement);
	}
```

The key thing to look at are these two lines:

```
							final Element liTemplate = navigationItem.equals(contextArtifact) ? activeLiTemplate : inactiveLiTemplate;

								final String navigationLabel = navigationItem.getLabel();
```

(There's a logic bug in the first of those lines, but ignore that; I'm in the middle of updating the code.)

These lines are indented too much: 7 and 8 tabs, respectively.

When I hit `Ctrl+Shift+F`, it brings the lines back to 5 and 6 tab indents, which is correct. But then when I hit `Ctrl+S` to save the code, it re-indents them to an incorrect number of indents.

So it's Bug 560889 all over again, just with extra indents rather than extra line breaks. Just like Bug 560889, if I remember to hit `Ctrl+Z` after saving and save again, I get "undo" the bad formatting things. But I don't always remember. And I don't even always see the things it screwed up, because they may be outside the current viewport.

I note that we have not had an Eclipse that would reliably format code since Eclipse 2019-12, so it it would be _really_ nice to get this fixed by Eclipse 2020-06. Thank you.