Community
Participate
Working Groups
Given: for (Iterator<String> iterator= (c.iterator() == null) ? otherIterator : anotherIterator; iterator.hasNext();) { String test= iterator.next(); System.out.println(test); } When: Converting iterable loop... Actual: for (String test : c) { System.out.println(test); } Expected: No cleanup The cleanup searches the matching iterator in any child node, whatever the intermediate nodes are. It's dangerous. We should search what is actually assigned.
New Gerrit change created: https://git.eclipse.org/r/163217
Gerrit change https://git.eclipse.org/r/163217 was merged to [master]. Commit: http://git.eclipse.org/c/jdt/eclipse.jdt.ui.git/commit/?id=18951b92faae80966a96e21e07af99ff2def6531
Are you aware, that we are in RC1, and that we have special rules for RC1 fixes? See https://www.eclipse.org/lists/platform-dev/msg02275.html https://www.eclipse.org/eclipse/development/plans/freeze_plan_4_16.php Please get +1 from JDT UI project lead or revert your change. Additionally: in the future, if you close a bug, set the Target Milestone to the appropriate value.
New Gerrit change created: https://git.eclipse.org/r/163575
Gerrit change https://git.eclipse.org/r/163575 was merged to [master]. Commit: http://git.eclipse.org/c/jdt/eclipse.jdt.ui.git/commit/?id=4d21d157f1ed62041f205bcda92f827e790d2393
+1 to revert for RC1.
New Gerrit change created: https://git.eclipse.org/r/164717
Gerrit change https://git.eclipse.org/r/164717 was merged to [master]. Commit: http://git.eclipse.org/c/jdt/eclipse.jdt.ui.git/commit/?id=eed8626a26d2370c3d958c88ee1ff9df7cbe8672
Versions need to be increased: https://download.eclipse.org/eclipse/downloads/drops4/I20200612-0650/buildlogs/reporeports/reports/versionChecks.html See 'IUs in current repo that increase versions but with qualifier only' section.
Verified for 4.17M3 using I20200818-0900 build
