Bug 563243 - Silence warning by adding type argument
Summary: Silence warning by adding type argument
Status: NEW
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Core (show other bugs)
Version: 4.15   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Matthias Becker CLA
QA Contact:
URL:
Whiteboard: stalebug
Keywords:
Depends on:
Blocks:
 
Reported: 2020-05-16 03:56 EDT by Matthias Becker CLA
Modified: 2022-09-11 06:56 EDT (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Matthias Becker CLA 2020-05-16 03:56:54 EDT
Similar to Bug 563103 let's silence some warnings in JDT code:
Comment 1 Stephan Herrmann CLA 2020-05-16 08:31:52 EDT
To be fair, it's not about silencing, those warnings were never reported :)

Removing/resolving @SuppressWarnings from these internal classes looks good to me, as no API is changed. 

Can you say a word about your selection: why exactly these three classes? 

As you can see in bug 422822 many of these @SuppressWarnings have been added during the migration to Java 1.6 (from 1.4). I see more candidates touched by bug 422822 that could be properly generified these days.

Some of these may be low hanging fruit, whereas others like JDTCompilerAdapter, e.g., may not be worth the effort: generifying would be a fairly big change, while OTOH this particular class is a slow mover, the last significant code change happened in 2010, so raw types here don't really cause a maintenance problem, since hardly any maintenance happens :)
Comment 2 Matthias Becker CLA 2020-05-16 08:55:11 EDT
(In reply to Stephan Herrmann from comment #1)
> To be fair, it's not about silencing, those warnings were never reported :)
Yes. You are right. 

> Removing/resolving @SuppressWarnings from these internal classes looks good
> to me, as no API is changed. 
> 
> Can you say a word about your selection: why exactly these three classes? 
It was quite random. I was doing similar changes for platform and came across these classes.
Comment 3 Manoj N Palat CLA 2020-05-19 01:58:45 EDT
Bulk move out of 4.16
Comment 4 Eclipse Genie CLA 2022-09-11 06:56:54 EDT
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.